benchmarks/sysbench: upgrade to sysbench-0.5

[sam_samgwydir.com]

Summary

Update the sysbench port to build from https://github.com/akopytov/sysbench . Tests are now written in lua and the port has been updated to reflect that.

Test Plan

Test inside poudriere

[editor_callfortesting.org]

The original sysbench author promised an updated release but may have abandoned the project. Percona has forked it for their purposes. Other suggestions in this situation?

[mat]

Makefile

16

This is the default and should be removed.

35

Remove && cd - ?

Also, isn't autogen.sh doing about the same thing as USES=autoreconf ?

41

Does this have to be pre-install ? if it is not needed for do-install to work, it should be post-install.

43

Don't use cp -r, use the COPYTREE_* macros.

https://www.freebsd.org/doc/en/books/porters-handbook/install.html

[sam_samgwydir.com]

updated according to mat's feedback.

[sam_samgwydir.com]

Moved from pre-install to post-install.

[mat]

When creating the pkg-plist file, best to run make makeplist

pkg-plist

73

This is not needed.

74

There's an empty line here.

[sam_samgwydir.com]

Ran make makeplist.

[sam_samgwydir.com]

Any more changes needed? If not, what is the next step here?

[sam_samgwydir.com]

If there aren't anymore changes needed, what is the best way to get in touch with a ports committer?

[editor_callfortesting.org]

mat, is this something you can commit?

[matthew]

Is there a PR for this?

Hmmm.... I can't seem to apply this patch to my ports tree.

lucid-nonsense:~...ports/benchmarks/sysbench:% arc patch D7388
A         files
Exception
Command failed with error #1!
COMMAND
(cd '/home/matthew/work/ports/' && mkdir 'files')

STDOUT
(empty)

STDERR
mkdir: files: File exists

(Run with `--trace` for a full exception trace.)

[matthew]

Having plumbed the mysteries of 'Download Raw Diff' I can run test builds. Seems all of mat's points have been addressed. Looks good to me

[sunpoet]

I've checked the upstream and found that 1.0.7 is released. Would you please update the patch to the latest release? Thanks!

BTW, do you want to take maintainership?

Makefile

16

GH_TAGNAME can be removed if you update it to 1.0.7.

files/patch-autogen.sh

6

I would suggest using USES=shebangfix and bash_CMD=/bin/sh instead.

[sam_samgwydir.com]

Upgrading to the 1.0 branch is non-trivial -- I'll take another crack at it if I have time.

[sunpoet]

Nevermind. I've updated it to 1.0.7 in r441740. :)

[sam_samgwydir.com]

Well done!