libthr: Fix LIBPTHREAD_QUEUE_FIFO range
ClosedPublic
Actions

Authored by aokblast on Thu, Oct 8, 6:54 PM.

Details

Reviewers

kib
markj

Commits

rG5fb07bbcd5d5: libthr: Fix LIBPTHREAD_QUEUE_FIFO range

Summary

LIBPTHREAD_QUEUE_FIFO is used in bitwise offset, we set the limit to
0~31 so that it won't cause undefined behavior. Also, create a new help
function to do getnv+strtol directly and check the boundary of the valid
value.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 77930
Build 74813: arc lint + arc unit

Event Timeline

aokblast created this revision.Thu, Oct 8, 6:54 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, Oct 8, 6:54 PM

aokblast requested review of this revision.Thu, Oct 8, 6:54 PM

Harbormaster completed remote builds in B77871: Diff 189087.Thu, Oct 8, 6:54 PM

In the summary:

Also, create a new helpER
function to do getEnv+strtol directly

lib/libthr/thread/thr_init.c
489
490	Why do we need to preserve errno?

Minor fixes

Harbormaster completed remote builds in B77930: Diff 189309.Fri, Oct 9, 10:16 PM

aokblast added inline comments.Fri, Oct 9, 10:16 PM

lib/libthr/thread/thr_init.c
490	strtol override errno. But maybe it is not important. Drop this now.

Please fix typos in the commit message.

This revision is now accepted and ready to land.Fri, Oct 9, 10:34 PM

Closed by commit rG5fb07bbcd5d5: libthr: Fix LIBPTHREAD_QUEUE_FIFO range (authored by aokblast). · Explain WhyTue, Oct 13, 7:28 PM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rG5fb07bbcd5d5: libthr: Fix LIBPTHREAD_QUEUE_FIFO range.

Revision Contents
Changeset List

Path

Size

lib/

libthr/

libthr.3

4 lines

thread/

thr_init.c

33 lines

Diff 189309

View Options

lib/libthr/libthr.3