libthr: Fix LIBPTHREAD_QUEUE_FIFO range
Needs ReviewPublic
Actions

Authored by aokblast on Thu, Oct 8, 6:54 PM.

Tags

None

Referenced Files

	F175291457: D60487.id189087.diff
	Fri, Oct 9, 5:30 PM

	F175288495: D60487.id.diff
	Fri, Oct 9, 5:05 PM

	F175287460: D60487.diff
	Fri, Oct 9, 4:57 PM

	F175253526: D60487.id189087.diff
	Fri, Oct 9, 11:13 AM

	F175214396: D60487.diff
	Fri, Oct 9, 4:06 AM

	F175206111: D60487.id189087.diff
	Fri, Oct 9, 2:30 AM

	F175196194: D60487.id189087.diff
	Fri, Oct 9, 12:44 AM

	F175196121: D60487.diff
	Fri, Oct 9, 12:44 AM

Subscribers

imp

ziaee

Details

Reviewers

kib
markj

Summary

LIBPTHREAD_QUEUE_FIFO is used in bitwise offset, we set the limit to
0~31 so that it won't cause undefined behavior. Also, create a new help
function to do getnv+strtol directly and check the boundary of the valid
value.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 77871
Build 74754: arc lint + arc unit

Event Timeline

aokblast created this revision.Thu, Oct 8, 6:54 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, Oct 8, 6:54 PM

aokblast requested review of this revision.Thu, Oct 8, 6:54 PM

Harbormaster completed remote builds in B77871: Diff 189087.Thu, Oct 8, 6:54 PM

In the summary:

Also, create a new helpER
function to do getEnv+strtol directly

lib/libthr/thread/thr_init.c
489
490	Why do we need to preserve errno?

Revision Contents
Changeset List

Path

Size

lib/

libthr/

libthr.3

4 lines

thread/

thr_init.c

39 lines

Diff 189087

View Options

lib/libthr/libthr.3