ipfilter: fix inverted range check on the lookup iterator unit
ClosedPublic
Actions

Authored by markj on Wed, Sep 16, 12:32 PM.

Details

Reviewers

Commits

rGcb035c19c3e7: ipfilter: fix inverted range check on the lookup iterator unit

Summary

ipf_lookup_iterate() validates iter.ili_unit with

if (iter.ili_unit < IPL_LOGALL && iter.ili_unit > IPL_LOGMAX)

or alternatively,

if (iter.ili_unit < -1 && iter.ili_unit > 7)

ipf_lookup_add(), ipf_lookup_delete(), ipf_lookup_stats()
ipf_lookup_flush() validate with a ||

Submitted by calif.io for the OpenAI Patch The Planet program

Signed-off-by: Andrew Griffiths <andrew@calif.io>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76972
Build 73855: arc lint + arc unit

Event Timeline

markj created this revision.Wed, Sep 16, 12:32 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro, imp. · View Herald TranscriptWed, Sep 16, 12:32 PM

markj requested review of this revision.Wed, Sep 16, 12:32 PM

Harbormaster completed remote builds in B76972: Diff 186849.Wed, Sep 16, 12:32 PM

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Sep 25, 5:01 PM

Closed by commit rGcb035c19c3e7: ipfilter: fix inverted range check on the lookup iterator unit (authored by Andrew Griffiths <andrew@calif.io>, committed by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGcb035c19c3e7: ipfilter: fix inverted range check on the lookup iterator unit.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfilter/

netinet/

ip_lookup.c

2 lines

Diff 186849

View Options

sys/netpfil/ipfilter/netinet/ip_lookup.c

ipfilter: fix inverted range check on the lookup iterator unitClosedPublicActions