riscv: Preserve savectx return address with vector support
ClosedPublic
Actions

Authored by mchoo on Tue, Sep 15, 1:37 AM.

Details

Reviewers

br
jrtc27

Group Reviewers

riscv

Commits

rG99ed9753a5c5: riscv: Preserve savectx return address with vector support

Summary

Calling vector_state_store_savectx() overwrites ra with the address of
the following ret instruction. The ret consequently branches to itself
and prevents kernel dumps from progressing past dump_savectx().

Tail-call vector_state_store_savectx() so that it returns directly to
the original savectx() caller.

Fixes: d7a393095cfd ("riscv: Vector Extension (RVV) support.")
Sponsored by: FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 76915
Build 73798: arc lint + arc unit

Event Timeline

mchoo created this revision.Tue, Sep 15, 1:37 AM

Herald added subscribers: riscv, imp. · View Herald TranscriptTue, Sep 15, 1:37 AM

mchoo requested review of this revision.Tue, Sep 15, 1:37 AM

Harbormaster completed remote builds in B76915: Diff 186745.Tue, Sep 15, 1:37 AM

mchoo added reviewers: riscv, br.Tue, Sep 15, 1:37 AM

br accepted this revision.Tue, Sep 15, 6:40 AM

This revision is now accepted and ready to land.Tue, Sep 15, 6:40 AM

jrtc27 accepted this revision.Tue, Sep 15, 10:48 AM

ping @jhb for mentor approval

In D59689#1369873, @mchoo wrote:

ping @jhb for mentor approval

I know John well enough (and work with him) to state that my approval here is sufficient for you to land it, and if you want an Approved by: you can put me there

Closed by commit rG99ed9753a5c5: riscv: Preserve savectx return address with vector support (authored by mchoo). · Explain WhyTue, Sep 15, 2:07 PM

This revision was automatically updated to reflect the committed changes.

mchoo added a commit: rG99ed9753a5c5: riscv: Preserve savectx return address with vector support.