Page MenuHomeFreeBSD
Differential D59551

acpi_cpu: only report unmapped processor objects enabled in the MADT
ClosedPublic
Actions

Authored by seuros on Wed, Sep 9, 10:13 PM.
Tags
Referenced Files
F175279260: D59551.diff
Fri, Oct 9, 4:08 PM
F175275102: D59551.id186629.diff
Fri, Oct 9, 3:46 PM
F175255090: D59551.id186630.diff
Fri, Oct 9, 11:30 AM
F175182265: D59551.id186630.diff
Thu, Oct 8, 10:28 PM
F175172975: D59551.id186629.diff
Thu, Oct 8, 8:52 PM
Unknown Object (File)
Thu, Oct 8, 5:52 PM
Unknown Object (File)
Thu, Oct 8, 2:27 PM
Unknown Object (File)
Thu, Oct 8, 1:45 PM
View All 70 Files
Subscribers
None

Details

Reviewers
imp
adrian
olce
jhb
Commits
rG9a46a1439c46: acpi_cpu: only report unmapped processor objects enabled in the MADT
Summary

Firmware expose a DSDT sized for the largest SKU of the platform,
so a verbose boot prints an "ignored" line for every vacant
processor slot. A vacant slot has no enabled MADT entry; a CPU that
failed to come online does.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 76862
Build 73745: arc lint + arc unit

Event Timeline

seuros requested review of this revision.Wed, Sep 9, 10:13 PM
seuros created this revision.
Harbormaster completed remote builds in B76720: Diff 186310.Wed, Sep 9, 10:13 PM
adrian added projects: drivers, x86.Wed, Sep 9, 10:58 PM
adrian added a reviewer: jhb.

what platform did you see this on?

seuros added a comment.Wed, Sep 9, 11:12 PM

AMD64 , Raptor Lake+

Oldest machine are offline, so i didn't check.

olce accepted this revision.Fri, Sep 11, 10:15 AM

I'd suggest some function renames, but otherwise looks fine. I might do some followup changes.

sys/dev/acpica/acpi_cpu.c
166

Suggested better name.

Also, I'd remove the p in the name, and since it's an internal function, possible the full acpi_cpu prefix as well. Applicable as well to the other added function.

167

See previous inline comment.

This revision is now accepted and ready to land.Fri, Sep 11, 10:15 AM
seuros updated this revision to Diff 186629.Sun, Sep 13, 8:46 PM

adress olce comments

This revision now requires review to proceed.Sun, Sep 13, 8:46 PM
Harbormaster completed remote builds in B76862: Diff 186629.Sun, Sep 13, 8:46 PM
adrian accepted this revision.Sun, Sep 13, 8:47 PM
This revision is now accepted and ready to land.Sun, Sep 13, 8:47 PM
Closed by commit rG9a46a1439c46: acpi_cpu: only report unmapped processor objects enabled in the MADT (authored by seuros). · Explain WhySun, Sep 13, 8:49 PM
This revision was automatically updated to reflect the committed changes.
seuros added a commit: rG9a46a1439c46: acpi_cpu: only report unmapped processor objects enabled in the MADT.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
65 lines

Diff 186629

View Options

sys/dev/acpica/acpi_cpu.c

Loading...