Paths

Table of Contentst

Differential D59600

libc: Parenthesise qualifier-preserving function definitions
ClosedPublic
Actions

Authored by kfv on Fri, Sep 11, 9:40 PM.

Tags

None

Referenced Files

	F172589694: D59600.id186593.diff
	Sat, Sep 19, 12:30 PM

	F172561227: D59600.id186489.diff
	Sat, Sep 19, 6:56 AM

	F172507497: D59600.id.diff
	Fri, Sep 18, 10:33 PM

	F172497918: D59600.id186489.diff
	Fri, Sep 18, 9:10 PM

	F172496288: D59600.id186593.diff
	Fri, Sep 18, 8:56 PM

	Unknown Object (File)
	Fri, Sep 18, 8:08 AM

	Unknown Object (File)
	Thu, Sep 17, 9:10 PM

	Unknown Object (File)
	Wed, Sep 16, 6:39 PM

View All 22 Files

Subscribers

Details

Reviewers

dteske
fuz
andrew

Commits

rGc389738f21c0: libc: Parenthesise qualifier-preserving function definitions

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76784
Build 73667: arc lint + arc unit

Event Timeline

kfv created this revision.Fri, Sep 11, 9:40 PM

Herald added a reviewer: andrew. · View Herald TranscriptFri, Sep 11, 9:40 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

kfv requested review of this revision.Fri, Sep 11, 9:40 PM

Harbormaster completed remote builds in B76784: Diff 186489.Fri, Sep 11, 9:40 PM

What is this change required for?

This is required to prevent function-like macros with the same name from being expanded in the definitions once they become active in a later C mode. Without the parentheses, the declarator is rewritten and will not compile. This style is used for similar cases such as mempcpy() too.

I wasn't planning to include a description in the commit body, but perhaps a brief explanation like the one above would be useful?

Yes, please include this explanation in the commit body. It appears somewhat puzzling otherwise.
LGTM and approved for commit.

This revision is now accepted and ready to land.Sat, Sep 12, 10:57 AM

Closed by commit rGc389738f21c0: libc: Parenthesise qualifier-preserving function definitions (authored by kfv). · Explain WhySun, Sep 13, 12:33 PM

This revision was automatically updated to reflect the committed changes.

kfv added a commit: rGc389738f21c0: libc: Parenthesise qualifier-preserving function definitions.

Revision Contents
Changeset List

Path

Size

lib/

libc/

aarch64/

string/

2 lines

amd64/

string/

2 lines

stdlib/

6 lines

string/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

sys/

libkern/

2 lines

Diff 186489

lib/libc/aarch64/string/strpbrk.c

Loading...

lib/libc/amd64/string/strpbrk.c

Loading...

lib/libc/stdlib/bsearch.c

Loading...

lib/libc/string/memchr.c

Loading...

lib/libc/string/memmem.c

Loading...

lib/libc/string/memrchr.c

Loading...

lib/libc/string/strcasestr.c

Loading...

lib/libc/string/strchr.c

Loading...

lib/libc/string/strnstr.c

Loading...

lib/libc/string/strpbrk.c

Loading...

lib/libc/string/strrchr.c

Loading...

lib/libc/string/strstr.c

Loading...

lib/libc/string/wcschr.c

Loading...

lib/libc/string/wcspbrk.c

Loading...

lib/libc/string/wcsrchr.c

Loading...

lib/libc/string/wcsstr.c

Loading...

lib/libc/string/wmemchr.c

Loading...

sys/libkern/strchrnul.c

Loading...