Page MenuHomeFreeBSD
Differential D59596

intel/intel_pmc: Add support for Cannon Lake through Meteor Lake
Needs ReviewPublic
Actions

Authored by seuros on Fri, Sep 11, 8:47 PM.
Tags
Referenced Files
F172577038: D59596.id186483.diff
Sat, Sep 19, 9:51 AM
F172538393: D59596.id.diff
Sat, Sep 19, 3:00 AM
Unknown Object (File)
Fri, Sep 18, 8:38 PM
Unknown Object (File)
Wed, Sep 16, 3:56 PM
Unknown Object (File)
Wed, Sep 16, 3:41 PM
Unknown Object (File)
Wed, Sep 16, 4:44 AM
Unknown Object (File)
Wed, Sep 16, 4:16 AM
Unknown Object (File)
Tue, Sep 15, 6:42 PM
View All 18 Files
Subscribers
dteske
imp
ziaee

Details

Reviewers
olce
adrian
ziaee
mashtizadeh_gmail.com
Summary

Match the platform by CPU model and attach on acpi with PWRM at
0xfe000000; the PMC is not PCI-enumerable on these platforms.
SLP_S0_RES offsets and granularities follow each generation's PCH
Family Datasheet Volume 2. A mismatch between the LPIT residency
counter address and SLP_S0_RES is reported on attach.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 76783
Build 73666: arc lint + arc unit

Event Timeline

seuros created this revision.Fri, Sep 11, 8:47 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Sep 11, 8:47 PM
seuros requested review of this revision.Fri, Sep 11, 8:47 PM
Harbormaster completed remote builds in B76783: Diff 186483.Fri, Sep 11, 8:47 PM
seuros added a project: drivers.Fri, Sep 11, 8:48 PM
seuros added a parent revision: D54881: intel/intelpmc: Add Intel PMC Core driver.
seuros retitled this revision from intel_pmc: Add support for Cannon Lake through Meteor Lake to intel/intel_pmc: Add support for Cannon Lake through Meteor Lake.
seuros added a reviewer: ziaee.Fri, Sep 11, 9:19 PM
imp added a reviewer: mashtizadeh_gmail.com.Sat, Sep 12, 7:39 PM
seuros mentioned this in D54881: intel/intelpmc: Add Intel PMC Core driver.Sun, Sep 13, 2:28 PM
adrian accepted this revision.Sun, Sep 13, 4:26 PM
This revision is now accepted and ready to land.Sun, Sep 13, 4:26 PM
ziaee added a comment.Mon, Sep 14, 12:45 PM

manpage changes looks good. i suppose i can test this now that it supports alder lake.

share/man/man4/intel_pmc.4
13–20
seuros added a subscriber: dteske.Mon, Sep 14, 12:48 PM

Yes! Your Alder lake should attach with this diff.

@dteske also has AL from Framework.

seuros added inline comments.Mon, Sep 14, 12:52 PM
share/man/man4/intel_pmc.4
13–20

this diff need a rebase, that verbose code don't exist in the Diff that was merged.

seuros updated this revision to Diff 186658.Mon, Sep 14, 1:27 PM

rebase.

This revision now requires review to proceed.Mon, Sep 14, 1:27 PM
Harbormaster completed remote builds in B76878: Diff 186658.Mon, Sep 14, 1:27 PM
seuros updated this revision to Diff 186665.Mon, Sep 14, 2:13 PM
This comment was removed by seuros.
Harbormaster completed remote builds in B76882: Diff 186665.Mon, Sep 14, 2:13 PM
seuros marked an inline comment as done.Mon, Sep 14, 2:13 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
40 lines
sys/
conf/
2 lines
dev/
intel/
359 lines
modules/
intel_pmc/
2 lines

Diff 186483

View Options

share/man/man4/intel_pmc.4

Loading...
View Options

sys/conf/files.x86

Loading...
View Options

sys/dev/intel/intel_pmc.c

Loading...
View Options

sys/modules/intel_pmc/Makefile

Loading...