Page MenuHomeFreeBSD
Differential D58757

linuxkpi: Add `hrtimer_setup()`
ClosedPublic
Actions

Authored by dumbbell on Aug 10 2026, 5:26 PM.
Tags
Referenced Files
F171143909: D58757.id.diff
Tue, Sep 8, 11:54 PM
F171143260: D58757.id183792.diff
Tue, Sep 8, 11:48 PM
F171125817: D58757.id186176.diff
Tue, Sep 8, 9:03 PM
F171125749: D58757.id186168.diff
Tue, Sep 8, 9:03 PM
F171125452: D58757.id186167.diff
Tue, Sep 8, 9:00 PM
F171125069: D58757.id186174.diff
Tue, Sep 8, 8:57 PM
Unknown Object (File)
Mon, Sep 7, 9:20 AM
Unknown Object (File)
Sun, Sep 6, 3:55 PM
View All 32 Files
Subscribers
bz
emaste
imp

Details

Reviewers
bz
Group Reviewers
linuxkpi
Commits
rG9273fe8ed2ad: linuxkpi: Add `hrtimer_setup()`
Summary

hrtimer_setup() replaces hrtimer_init() in Linux 6.15. The API and the role are the same, except:

  • it takes the function callback as argument
  • if function is NULL, it assigns a default callback

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dumbbell created this revision.Aug 10 2026, 5:26 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptAug 10 2026, 5:26 PM
dumbbell requested review of this revision.Aug 10 2026, 5:26 PM
dumbbell edited the summary of this revision. (Show Details)
dumbbell added a parent revision: D58254: linuxkpi: Define `for_each_if()`.Aug 10 2026, 5:34 PM
dumbbell added a child revision: D58758: linuxkpi: Add `timer64_to_tm()`.
emaste added a project: linuxkpi.Mon, Aug 17, 4:58 PM
bz added a subscriber: bz.Sat, Sep 5, 9:38 AM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/hrtimer.h
58

Does that mean this is LINUXKPI_VERSION < 61500? We should probably start hiding this (in a separate pass) to not run into similar problems as we did with, e.g., https://reviews.freebsd.org/D58834, carrying old stuff around endlessly.

76

I know it's weird given everything in here is linux_, but can we call new stuff linuxkpi_ and no longer linux_ ?

sys/compat/linuxkpi/common/src/linux_hrtimer.c
108

This is actually exposed on Linux (probably shouldn't have been there either). Want to call it linuxkpi_hrtimer_dummy_timeout so we could make it public in the future and document that it is a public KPI?

dumbbell updated this revision to Diff 186167.Mon, Sep 7, 7:30 PM

Address feedback from @bz.

dumbbell updated this revision to Diff 186168.Mon, Sep 7, 7:30 PM
dumbbell marked 3 inline comments as done.

Fix build failure

bz accepted this revision.Mon, Sep 7, 7:44 PM
bz added inline comments.
sys/compat/linuxkpi/common/src/linux_hrtimer.c
109

__unused but I am fine even without it of if you just add ti before commit.

This revision is now accepted and ready to land.Mon, Sep 7, 7:44 PM
dumbbell updated this revision to Diff 186174.Mon, Sep 7, 8:29 PM

Add __unused after unused arguent in linuxkpi_hrtimer_dummy_timeout() as suggested by @bz.

This revision now requires review to proceed.Mon, Sep 7, 8:29 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Sep 7, 8:33 PM
Closed by commit rG9273fe8ed2ad: linuxkpi: Add `hrtimer_setup()` (authored by dumbbell). · Explain Why
This revision was automatically updated to reflect the committed changes.
dumbbell added a commit: rG9273fe8ed2ad: linuxkpi: Add `hrtimer_setup()`.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
19 lines
src/
17 lines

Diff 186176

View Options

sys/compat/linuxkpi/common/include/linux/hrtimer.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_hrtimer.c

Loading...