Page MenuHomeFreeBSD
Differential D59272

libc: Fix C23 version macro visibility
ClosedPublic
Actions

Authored by des on Sun, Aug 30, 2:40 PM.
Tags
None
Referenced Files
F169564932: D59272.id185440.diff
Tue, Sep 1, 10:44 PM
F169506000: D59272.diff
Tue, Sep 1, 6:10 PM
F169495800: D59272.id.diff
Tue, Sep 1, 5:16 PM
F169483109: D59272.diff
Tue, Sep 1, 4:07 PM
Unknown Object (File)
Mon, Aug 31, 5:03 AM
Unknown Object (File)
Mon, Aug 31, 2:25 AM
Unknown Object (File)
Mon, Aug 31, 1:37 AM
Unknown Object (File)
Sun, Aug 30, 5:23 PM
View All 11 Files
Subscribers
imp

Details

Reviewers
dteske
fuz
kfv
Commits
rG5076e9b5463a: libc: Fix C23 version macro visibility
Summary

In headers that existed prior to C23, these should be visible only in
C23 or BSD mode.

Fixes: 0fe73dcf7c32 ("libc: Add <assert.h> C23 feature test macro")
Fixes: 1f09e354297c ("sys/limits.h: Add BOOL_MAX, BITINT_MAXWIDTH, and C23 feature test macro")
Fixes: cd0727ec709b ("libc: Add <stdio.h> C23 feature test macro")
Fixes: fc9d02cb29ed ("libc: Add <time.h> C23 feature test macro")
Fixes: 4aeed6e9d213 ("libc: Add <setjmp.h> C23 feature test macro")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76331
Build 73214: arc lint + arc unit

Event Timeline

des created this revision.Sun, Aug 30, 2:40 PM
Herald added a subscriber: imp. · View Herald TranscriptSun, Aug 30, 2:40 PM
des requested review of this revision.Sun, Aug 30, 2:40 PM
Harbormaster completed remote builds in B76331: Diff 185440.Sun, Aug 30, 2:40 PM
dteske accepted this revision.Sun, Aug 30, 2:46 PM

LGTM. Looks to be exactly as we discussed on August 25th (thumbs up)

This revision is now accepted and ready to land.Sun, Aug 30, 2:46 PM
kfv accepted this revision.Sun, Aug 30, 3:22 PM
fuz accepted this revision.Sun, Aug 30, 3:38 PM

This looks reasonable.
Approved for commit.

des added a comment.Sun, Aug 30, 5:56 PM
In D59272#1359837, @dteske wrote:

LGTM. Looks to be exactly as we discussed on August 25th (thumbs up)

It is, but I shouldn't have had to do it myself.

Closed by commit rG5076e9b5463a: libc: Fix C23 version macro visibility (authored by des). · Explain WhySun, Aug 30, 5:57 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG5076e9b5463a: libc: Fix C23 version macro visibility.

Revision Contents
Changeset List

PathSize
include/
2 lines
6 lines
6 lines
6 lines
6 lines
sys/
sys/
6 lines

Diff 185440

View Options

include/assert.h

Loading...
View Options

include/limits.h

Loading...
View Options

include/setjmp.h

Loading...
View Options

include/stdio.h

Loading...
View Options

include/time.h

Loading...
View Options

sys/sys/stdatomic.h

Loading...