Differential D59272

libc: Fix C23 version macro visibility
AcceptedPublic
Actions

Authored by des on Sun, Aug 30, 2:40 PM.

Tags

None

Referenced Files

	F168909927: D59272.id185440.diff
	Sun, Aug 30, 5:23 PM

	F168903923: D59272.id.diff
	Sun, Aug 30, 4:46 PM

	F168900425: D59272.diff
	Sun, Aug 30, 4:24 PM

	F168893968: D59272.id185440.diff
	Sun, Aug 30, 3:45 PM

Subscribers

Details

Reviewers

dteske
fuz
kfv

Summary

In headers that existed prior to C23, these should be visible only in
C23 or BSD mode.

Fixes: 0fe73dcf7c32 ("libc: Add <assert.h> C23 feature test macro")
Fixes: 1f09e354297c ("sys/limits.h: Add BOOL_MAX, BITINT_MAXWIDTH, and C23 feature test macro")
Fixes: cd0727ec709b ("libc: Add <stdio.h> C23 feature test macro")
Fixes: fc9d02cb29ed ("libc: Add <time.h> C23 feature test macro")
Fixes: 4aeed6e9d213 ("libc: Add <setjmp.h> C23 feature test macro")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76331
Build 73214: arc lint + arc unit

Event Timeline

des created this revision.Sun, Aug 30, 2:40 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Aug 30, 2:40 PM

des requested review of this revision.Sun, Aug 30, 2:40 PM

Harbormaster completed remote builds in B76331: Diff 185440.Sun, Aug 30, 2:40 PM

LGTM. Looks to be exactly as we discussed on August 25th (thumbs up)

This revision is now accepted and ready to land.Sun, Aug 30, 2:46 PM

kfv accepted this revision.Sun, Aug 30, 3:22 PM

This looks reasonable.
Approved for commit.

Revision Contents
Changeset List

Path

Size

include/

2 lines

6 lines

6 lines

6 lines

6 lines

sys/

sys/

6 lines

Diff 185440

include/assert.h

Loading...

include/limits.h

Loading...

include/setjmp.h

Loading...

include/stdio.h

Loading...

include/time.h

Loading...

sys/sys/stdatomic.h

Loading...