Page MenuHomeFreeBSD
Differential D59267

name: add cni-dnsname
ClosedPublic
Actions

Authored by adrian on Sat, Aug 29, 7:29 PM.
Tags
Referenced Files
F170852595: D59267.id185419.diff
Mon, Sep 7, 1:26 AM
F170831479: D59267.diff
Sun, Sep 6, 9:58 PM
F170804343: D59267.id185936.diff
Sun, Sep 6, 6:02 PM
F170789033: D59267.id.diff
Sun, Sep 6, 3:36 PM
Unknown Object (File)
Sat, Sep 5, 7:06 PM
Unknown Object (File)
Sat, Sep 5, 6:15 PM
Unknown Object (File)
Sat, Sep 5, 6:07 PM
Unknown Object (File)
Sat, Sep 5, 1:35 PM
View All 23 Files
Subscribers
arrowd
lwhsu

Details

Reviewers
arrowd
Group Reviewers
Ports Committers
Commits
R11:98dc52b70391: name: add cni-dnsname
Summary

this is a CNI plugin for podman containers which allows for
dynamic registration of containers into a local dns zone.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76325
Build 73208: arc lint + arc unit

Event Timeline

adrian requested review of this revision.Sat, Aug 29, 7:29 PM
adrian created this revision.
Harbormaster completed remote builds in B76325: Diff 185419.Sat, Aug 29, 7:29 PM
lwhsu added a subscriber: lwhsu.Sun, Aug 30, 12:50 PM

Would it be more suitable to be in dns category?

adrian added a comment.Mon, Aug 31, 2:44 AM
In D59267#1359826, @lwhsu wrote:

Would it be more suitable to be in dns category?

not sure; its part of container infra rather than DNS infra and we don't specifically have a container infra top level directory. So I put it where podman lives (ie sysutils).

arrowd added a subscriber: arrowd.Sat, Sep 5, 12:23 PM
arrowd added inline comments.
sysutils/cni-dnsname/Makefile
4

Should be sysutils, possibly followed by net.

sysutils/cni-dnsname/distinfo
5

Re-run make makesum after changing the category:

=> go/sysutils_cni-dnsname/cni-dnsname-v1.3.1/v1.3.1.mod is not in /usr/ports/sysutils/cni-dnsname/distinfo.                       
=> Either /usr/ports/sysutils/cni-dnsname/distinfo is out of date, or
=> go/sysutils_cni-dnsname/cni-dnsname-v1.3.1/v1.3.1.mod is spelled incorrectly.
adrian updated this revision to Diff 185936.Sat, Sep 5, 4:34 PM

feedback from arrowd

Harbormaster completed remote builds in B76571: Diff 185936.Sat, Sep 5, 4:34 PM
adrian marked 2 inline comments as done.Sat, Sep 5, 4:34 PM

fixed, thanks!

adrian added projects: Contributor Reviewers (ports), Ports Committers.Sat, Sep 5, 4:35 PM
adrian added a reviewer: Ports Committers.
arrowd accepted this revision.Sat, Sep 5, 5:21 PM

LGTM
Macro lgtm: LGTM LGTM

LGTM

This revision is now accepted and ready to land.Sat, Sep 5, 5:21 PM
Closed by commit R11:98dc52b70391: name: add cni-dnsname (authored by adrian). · Explain WhySat, Sep 5, 5:36 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: R11:98dc52b70391: name: add cni-dnsname.

Revision Contents
Changeset List

Diff 185419

View Options

sysutils/Makefile

Loading...
View Options

sysutils/cni-dnsname/Makefile

Loading...
View Options

sysutils/cni-dnsname/distinfo

Loading...
View Options

sysutils/cni-dnsname/files/patch-plugins_meta_dnsname_config.go

Loading...
View Options

sysutils/cni-dnsname/files/patch-plugins_meta_dnsname_files.go

Loading...
View Options

sysutils/cni-dnsname/files/patch-plugins_meta_dnsname_files__test.go

Loading...
View Options

sysutils/cni-dnsname/pkg-descr

Loading...