Page MenuHomeFreeBSD

tpm20: Correct 32-bit register helpers
ClosedPublic

Authored by kbowling on Fri, Aug 28, 1:16 AM.
Tags
None
Referenced Files
F170851939: D59244.id185299.diff
Mon, Sep 7, 1:20 AM
F170845032: D59244.id185299.diff
Mon, Sep 7, 12:12 AM
F170827336: D59244.id185672.diff
Sun, Sep 6, 9:17 PM
F170729498: D59244.id185299.diff
Sun, Sep 6, 6:31 AM
F170707152: D59244.diff
Sun, Sep 6, 3:23 AM
Unknown Object (File)
Sat, Sep 5, 5:13 PM
Unknown Object (File)
Sat, Sep 5, 5:13 PM
Unknown Object (File)
Sat, Sep 5, 10:01 AM
Subscribers

Details

Summary
OR4() reads only the low byte before writing the complete 32-bit
register.  Preserve all register bits by using a matching 32-bit read.

Make BIT() produce an unsigned value so masks containing bit 31 do not
rely on a signed left shift into the sign bit.

MFC after:      2 weeks

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped