rangelock: Reimplement _rangelock_cookie_assert()
ClosedPublic
Actions

Authored by markj on Thu, Aug 27, 1:28 PM.

Tags

None

Referenced Files

	F170019947: D59222.diff
	Thu, Sep 3, 6:42 AM

	F169898526: D59222.id185221.diff
	Wed, Sep 2, 10:06 PM

	F169773211: D59222.diff
	Wed, Sep 2, 12:53 PM

	Unknown Object (File)
	Wed, Sep 2, 8:10 AM

	Unknown Object (File)
	Wed, Sep 2, 4:02 AM

	Unknown Object (File)
	Tue, Sep 1, 10:12 AM

	Unknown Object (File)
	Tue, Sep 1, 2:23 AM

	Unknown Object (File)
	Mon, Aug 31, 7:29 PM

Subscribers

Details

Reviewers

kib
kevans

Commits

rG2e376cca379b: rangelock: Reimplement _rangelock_cookie_assert()

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76214
Build 73097: arc lint + arc unit

Event Timeline

markj created this revision.Thu, Aug 27, 1:28 PM

Herald added subscribers: olce, glebius, imp. · View Herald TranscriptThu, Aug 27, 1:28 PM

markj requested review of this revision.Thu, Aug 27, 1:28 PM

Harbormaster completed remote builds in B76214: Diff 185216.Thu, Aug 27, 1:28 PM

kib added inline comments.Thu, Aug 27, 2:08 PM

sys/kern/kern_rangelock.c
826	I would systematically add a value of entry->rl_q_flags to all printouts.
835	Same, I would print out the cookie value.
856	If cookie was not properly initialized, we can get there I believe.

Improve messages

Harbormaster completed remote builds in B76217: Diff 185221.Thu, Aug 27, 2:21 PM

kib accepted this revision.Thu, Aug 27, 2:45 PM

This revision is now accepted and ready to land.Thu, Aug 27, 2:45 PM

Closed by commit rG2e376cca379b: rangelock: Reimplement _rangelock_cookie_assert() (authored by markj). · Explain WhyThu, Aug 27, 11:30 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG2e376cca379b: rangelock: Reimplement _rangelock_cookie_assert().

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_rangelock.c

42 lines

uipc_shm.c

6 lines

Diff 185216

View Options

sys/kern/kern_rangelock.c