Details

Reviewers

jlduran
jrm
ashish
imp

Summary

Previously nanobsd.sh unconditionally sourced legacy.sh at startup.
Instead, source it on demand through the legacy() plan function, and
fall back to it only when NANO_PLAN is unset, with a warning so
existing configs know to set NANO_PLAN explicitly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76071
Build 72954: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Tue, Aug 25, 6:06 AM

Herald added a subscriber: imp. · View Herald TranscriptTue, Aug 25, 6:06 AM

senguptaangshuman17_gmail.com requested review of this revision.Tue, Aug 25, 6:06 AM

Harbormaster completed remote builds in B76071: Diff 184948.Tue, Aug 25, 6:06 AM

senguptaangshuman17_gmail.com added a parent revision: D58967: nanobsd: Allow overriding kernels in loader.conf.Tue, Aug 25, 6:07 AM

senguptaangshuman17_gmail.com added a child revision: D58968: nanobsd: Add basic update/rollback scripts.

senguptaangshuman17_gmail.com added reviewers: jlduran, jrm, ashish.Tue, Aug 25, 6:09 AM

senguptaangshuman17_gmail.com added a parent revision: D54187: nanobsd.sh: Start the transition away from 'legacy' config.Tue, Aug 25, 6:14 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76130: Diff 185007.Tue, Aug 25, 8:01 AM

senguptaangshuman17_gmail.com updated this revision to Diff 185111.Tue, Aug 25, 9:01 PM

Harbormaster completed remote builds in B76170: Diff 185111.Tue, Aug 25, 9:01 PM

This revision is just a placeholder for D54187?

In D59166#1357692, @jlduran wrote:

This revision is just a placeholder for D54187?

yes with just small modification in tools/tools/nanobsd/embedded/common where NANO_PLAN=embedded is defined

jlduran mentioned this in D58966: nanobsd: Put customizations in a separate file.Wed, Aug 26, 4:30 PM

In D59166#1357696, @senguptaangshuman17_gmail.com wrote:

In D59166#1357692, @jlduran wrote:

This revision is just a placeholder for D54187?

yes with just small modification in tools/tools/nanobsd/embedded/common where NANO_PLAN=embedded is defined