Page MenuHomeFreeBSD
Differential D59166

nanobsd: Source legacy.sh on demand instead of unconditionally
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Aug 25 2026, 6:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 24, 3:32 AM
Unknown Object (File)
Tue, Sep 22, 9:15 PM
Unknown Object (File)
Tue, Sep 22, 1:16 PM
Unknown Object (File)
Mon, Sep 21, 4:37 PM
Unknown Object (File)
Sat, Sep 19, 5:19 PM
Unknown Object (File)
Sat, Sep 19, 11:47 AM
Unknown Object (File)
Sat, Sep 12, 11:17 AM
Unknown Object (File)
Sat, Sep 12, 8:12 AM
View All Files
Subscribers
imp

Details

Reviewers
jlduran
jrm
ashish
imp
Summary

Previously nanobsd.sh unconditionally sourced legacy.sh at startup.
Instead, source it on demand through the legacy() plan function, and
fall back to it only when NANO_PLAN is unset, with a warning so
existing configs know to set NANO_PLAN explicitly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76071
Build 72954: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Aug 25 2026, 6:06 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 25 2026, 6:06 AM
senguptaangshuman17_gmail.com requested review of this revision.Aug 25 2026, 6:06 AM
Harbormaster completed remote builds in B76071: Diff 184948.Aug 25 2026, 6:06 AM
senguptaangshuman17_gmail.com added a parent revision: D58967: nanobsd: Allow overriding kernels in loader.conf.Aug 25 2026, 6:07 AM
senguptaangshuman17_gmail.com added a child revision: D58968: nanobsd: Add basic update/rollback scripts.
senguptaangshuman17_gmail.com added reviewers: jlduran, jrm, ashish.Aug 25 2026, 6:09 AM
senguptaangshuman17_gmail.com added a parent revision: D54187: nanobsd.sh: Start the transition away from 'legacy' config.Aug 25 2026, 6:14 AM
senguptaangshuman17_gmail.com updated this revision to Diff 185007.Aug 25 2026, 8:01 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76130: Diff 185007.Aug 25 2026, 8:01 AM
senguptaangshuman17_gmail.com updated this revision to Diff 185111.Aug 25 2026, 9:01 PM
Harbormaster completed remote builds in B76170: Diff 185111.Aug 25 2026, 9:01 PM
jlduran added a comment.Aug 25 2026, 9:18 PM

This revision is just a placeholder for D54187?

senguptaangshuman17_gmail.com added a comment.Aug 25 2026, 9:56 PM
In D59166#1357692, @jlduran wrote:

This revision is just a placeholder for D54187?

yes with just small modification in tools/tools/nanobsd/embedded/common where NANO_PLAN=embedded is defined

jlduran mentioned this in D58966: nanobsd: Put customizations in a separate file.Aug 26 2026, 4:30 PM
jlduran added a comment.Thu, Aug 27, 6:50 PM
In D59166#1357696, @senguptaangshuman17_gmail.com wrote:
In D59166#1357692, @jlduran wrote:

This revision is just a placeholder for D54187?

yes with just small modification in tools/tools/nanobsd/embedded/common where NANO_PLAN=embedded is defined

In that case, please explicitly add @imp as a reviewer or suggest changes in D54187.
I have to revisit is_defined() because it's been a while.

senguptaangshuman17_gmail.com added a reviewer: imp.Thu, Aug 27, 7:39 PM
senguptaangshuman17_gmail.com removed a parent revision: D54187: nanobsd.sh: Start the transition away from 'legacy' config.Thu, Aug 27, 9:31 PM
senguptaangshuman17_gmail.com updated this revision to Diff 185271.Thu, Aug 27, 9:36 PM
Harbormaster completed remote builds in B76261: Diff 185271.Thu, Aug 27, 9:36 PM
senguptaangshuman17_gmail.com updated this revision to Diff 185391.Sat, Aug 29, 9:30 AM
Harbormaster completed remote builds in B76306: Diff 185391.Sat, Aug 29, 9:30 AM

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
dhcpd/
2 lines
6 lines
7 lines
pcengines/
2 lines
rescue/
2 lines

Diff 184948

View Options

tools/tools/nanobsd/dhcpd/common

Loading...
View Options

tools/tools/nanobsd/legacy.sh

Loading...
View Options

tools/tools/nanobsd/nanobsd.sh

Loading...
View Options

tools/tools/nanobsd/pcengines/common.conf

Loading...
View Options

tools/tools/nanobsd/rescue/common

Loading...