if_bnxt: add bitmap search/test-and-set helpers
ClosedPublic
Actions

Authored by sumit.saxena_broadcom.com on Aug 3 2026, 12:17 PM.

Details

Reviewers

chandrakanth.patil_broadcom.com
sreekanth.reddy_broadcom.com
gallatin
shurd

Commits

rGaef2db6fac23: if_bnxt: add bitmap search/test-and-set helpers

Summary

Add bnxt_find_next_zero_bit()/bnxt_find_first_zero_bit()/
bnxt_test_and_set_bit()/bnxt_find_next_bit()/bnxt_test_and_clear_bit(),
wrapping sys/bitstring.h's bit_test()/bit_set()/bit_clear() with the
find-first/find-next and atomic test-and-flip semantics the kTLS
key-context ID allocator needs; bitstring.h has no equivalent
primitives.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sumit.saxena_broadcom.com created this revision.Aug 3 2026, 12:17 PM

Herald added a reviewer: shurd. · View Herald TranscriptAug 3 2026, 12:17 PM

sumit.saxena_broadcom.com requested review of this revision.Aug 3 2026, 12:17 PM

Can't most these just be implemented in terms of the already existing primitives in sys/bitstring.h? Eg, bnxt_find_first_zero_bit -> bit_ffc bnxt_find_next_zero_bit -> bit_ffc_at bnxt_find_next_bit > bit_ffs_

The ones that can't have misleading naming. test_and_set and test_and_clear sound atomic, but these aren't. I might include non-atomic in the names.

This revision now requires changes to proceed.Aug 3 2026, 11:25 PM

In D58605#1345369, @gallatin wrote:

Can't most these just be implemented in terms of the already existing primitives in sys/bitstring.h? Eg, bnxt_find_first_zero_bit -> bit_ffc bnxt_find_next_zero_bit -> bit_ffc_at bnxt_find_next_bit > bit_ffs_

The ones that can't have misleading naming. test_and_set and test_and_clear sound atomic, but these aren't. I might include non-atomic in the names.

I think we can do that. I will fix it up.

sumit.saxena_broadcom.com updated this revision to Diff 184657.Aug 21 2026, 3:25 PM

gallatin accepted this revision.Wed, Oct 7, 3:48 PM

This revision is now accepted and ready to land.Wed, Oct 7, 3:48 PM

Closed by commit rGaef2db6fac23: if_bnxt: add bitmap search/test-and-set helpers (authored by sumit.saxena_broadcom.com). · Explain WhyFri, Oct 9, 10:13 AM

This revision was automatically updated to reflect the committed changes.

sumit.saxena_broadcom.com added a commit: rGaef2db6fac23: if_bnxt: add bitmap search/test-and-set helpers.

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 10:13 AM