Differential D58933

nanobsd: Add an err() convenience function
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Tue, Aug 18, 10:41 PM.

Tags

None

Referenced Files

	F170175858: D58933.diff
	Thu, Sep 3, 6:03 PM

	F170156947: D58933.diff
	Thu, Sep 3, 4:42 PM

	F170052148: D58933.id184984.diff
	Thu, Sep 3, 9:13 AM

	F170050645: D58933.id185244.diff
	Thu, Sep 3, 9:07 AM

	F170043112: D58933.id185243.diff
	Thu, Sep 3, 8:30 AM

	F170030639: D58933.id184816.diff
	Thu, Sep 3, 7:30 AM

	F170008317: D58933.id184448.diff
	Thu, Sep 3, 5:57 AM

	F169989852: D58933.id184286.diff
	Thu, Sep 3, 5:02 AM

View All 62 Files

Subscribers

Details

Reviewers

jrm
ashish
jlduran

Summary

Add err() to echo a message to stderr and exit with the NanoBSD
fatal error code. Use it in the three existing echo and exit sites.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75690
Build 72573: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Tue, Aug 18, 10:41 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Aug 18, 10:41 PM

senguptaangshuman17_gmail.com requested review of this revision.Tue, Aug 18, 10:41 PM

Harbormaster completed remote builds in B75690: Diff 184286.Tue, Aug 18, 10:41 PM

senguptaangshuman17_gmail.com added a parent revision: D58932: nanobsd: Add comments to defaults.sh, legacy.sh.Tue, Aug 18, 10:41 PM

senguptaangshuman17_gmail.com added a child revision: D58934: nanobsd: Add _xxx_includes.subr.

senguptaangshuman17_gmail.com added reviewers: jrm, ashish, jlduran.Wed, Aug 19, 5:19 AM

senguptaangshuman17_gmail.com updated this revision to Diff 184448.Thu, Aug 20, 10:09 AM

Harbormaster completed remote builds in B75782: Diff 184448.Thu, Aug 20, 10:09 AM

jlduran accepted this revision.Thu, Aug 20, 3:23 PM

This revision is now accepted and ready to land.Thu, Aug 20, 3:23 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184816.Sun, Aug 23, 11:00 PM

This revision now requires review to proceed.Sun, Aug 23, 11:00 PM

Harbormaster completed remote builds in B76002: Diff 184816.Sun, Aug 23, 11:00 PM

No code changes in this commit. An earlier commit in the stack (D58931) needed a commit-message reword per review feedback, which required a bottom-up arc diff refresh of every commit above it to keep the stack applying cleanly. That refresh is what reset this revision's accepted status, not a content change.

@jlduran, could you re-accept when you get a chance?

senguptaangshuman17_gmail.com updated this revision to Diff 184984.Tue, Aug 25, 6:13 AM

Harbormaster completed remote builds in B76107: Diff 184984.Tue, Aug 25, 6:13 AM

senguptaangshuman17_gmail.com updated this revision to Diff 185243.Thu, Aug 27, 9:31 PM

senguptaangshuman17_gmail.com added a child revision: D58963: nanobsd: Disable dumpdev.

senguptaangshuman17_gmail.com removed a child revision: D58934: nanobsd: Add _xxx_includes.subr.

Harbormaster completed remote builds in B76233: Diff 185243.Thu, Aug 27, 9:32 PM

senguptaangshuman17_gmail.com updated this revision to Diff 185244.Thu, Aug 27, 9:32 PM

Harbormaster completed remote builds in B76234: Diff 185244.Thu, Aug 27, 9:32 PM

Revision Contents
Changeset List

Path

Size

tools/

tools/

nanobsd/

15 lines

Diff 184286

tools/tools/nanobsd/defaults.sh

Loading...