Page MenuHomeFreeBSD
Differential D58932

nanobsd: Add comments to defaults.sh, legacy.sh
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Tue, Aug 18, 10:38 PM.
Tags
None
Referenced Files
F168816435: D58932.id184815.diff
Sun, Aug 30, 7:17 AM
F168803303: D58932.id184985.diff
Sun, Aug 30, 5:58 AM
F168802949: D58932.id184815.diff
Sun, Aug 30, 5:56 AM
Unknown Object (File)
Sat, Aug 29, 1:54 PM
Unknown Object (File)
Sat, Aug 29, 11:01 AM
Unknown Object (File)
Fri, Aug 28, 11:07 PM
Unknown Object (File)
Fri, Aug 28, 4:35 PM
Unknown Object (File)
Fri, Aug 28, 3:24 PM
View All 42 Files
Subscribers
imp

Details

Reviewers
imp
jrm
jlduran
ashish
Summary

Add comments to defaults.sh and legacy.sh function definitions.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75689
Build 72572: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Tue, Aug 18, 10:38 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Aug 18, 10:38 PM
senguptaangshuman17_gmail.com requested review of this revision.Tue, Aug 18, 10:38 PM
Harbormaster completed remote builds in B75689: Diff 184285.Tue, Aug 18, 10:38 PM
senguptaangshuman17_gmail.com added a parent revision: D58931: nanobsd: Normalize style in common functions.Tue, Aug 18, 10:38 PM
senguptaangshuman17_gmail.com added a child revision: D58933: nanobsd: Add an err() convenience function.Tue, Aug 18, 10:41 PM
imp accepted this revision.Wed, Aug 19, 5:06 AM
This revision is now accepted and ready to land.Wed, Aug 19, 5:06 AM
senguptaangshuman17_gmail.com added reviewers: jrm, jlduran, ashish.Wed, Aug 19, 5:18 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184447.Thu, Aug 20, 10:09 AM
This revision now requires review to proceed.Thu, Aug 20, 10:09 AM
Harbormaster completed remote builds in B75781: Diff 184447.Thu, Aug 20, 10:09 AM
senguptaangshuman17_gmail.com added a comment.EditedThu, Aug 20, 10:16 AM

There are no changes done in this commit, just because of the previous commit update, I thought all the commits needed to be updated as things have been rebased. So pushed an update to all thus removing this differential's accepted status.

So @imp please accept this differential again.

senguptaangshuman17_gmail.com updated this revision to Diff 184815.Sun, Aug 23, 11:00 PM
Harbormaster completed remote builds in B76001: Diff 184815.Sun, Aug 23, 11:00 PM
senguptaangshuman17_gmail.com added a comment.Sun, Aug 23, 11:05 PM

No code changes in this commit, same as before. An earlier commit in the stack (D58931) needed a commit-message reword per review feedback, which required a bottom-up arc diff refresh of everything above it, and that's what reset the accepted status again.

@imp, could you re-accept when you get a chance? Sorry for the repeat ping.

senguptaangshuman17_gmail.com updated this revision to Diff 184985.Tue, Aug 25, 6:13 AM
Harbormaster completed remote builds in B76108: Diff 184985.Tue, Aug 25, 6:13 AM
senguptaangshuman17_gmail.com updated this revision to Diff 185242.Thu, Aug 27, 9:31 PM
senguptaangshuman17_gmail.com edited the summary of this revision. (Show Details)

Fix typo in Avila reference and normalize doc comments

Harbormaster completed remote builds in B76232: Diff 185242.Thu, Aug 27, 9:32 PM

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
128 lines
17 lines

Diff 184285

View Options

tools/tools/nanobsd/defaults.sh

Loading...
View Options

tools/tools/nanobsd/legacy.sh

Loading...