bhyve: Tidy lobits handling in pci_passthru
ClosedPublic
Actions

Authored by jhb on Mon, Aug 17, 5:55 PM.

Tags

None

Referenced Files

	F170986093: D58894.id185166.diff
	Tue, Sep 8, 12:48 AM

	Unknown Object (File)
	Sat, Sep 5, 8:16 PM

	Unknown Object (File)
	Sat, Sep 5, 1:02 PM

	Unknown Object (File)
	Sat, Sep 5, 8:15 AM

	Unknown Object (File)
	Fri, Sep 4, 11:14 PM

	Unknown Object (File)
	Thu, Sep 3, 11:08 PM

	Unknown Object (File)
	Thu, Sep 3, 3:04 PM

	Unknown Object (File)
	Wed, Sep 2, 2:22 AM

Subscribers

Details

Reviewers

bnovkov

Group Reviewers

bhyve

Commits

rG0ffad4ce5655: bhyve: Tidy lobits handling in pci_passthru

Summary

The lobits field in the "physical" BAR settings is never used, so don't bother setting it.

Expand the comment explaining why the existing lobits are preserved (namely, to preserve the prefetch flag on memory BARs).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75654
Build 72537: arc lint + arc unit

Event Timeline

jhb created this revision.Mon, Aug 17, 5:55 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMon, Aug 17, 5:55 PM

Harbormaster completed remote builds in B75654: Diff 184209.Mon, Aug 17, 5:55 PM

jhb requested review of this revision.Mon, Aug 17, 5:55 PM

jhb added a parent revision: D58893: bhyve: Refactor initial PCI BAR setup.

bnovkov accepted this revision.Fri, Aug 21, 1:39 PM

This revision is now accepted and ready to land.Fri, Aug 21, 1:39 PM

Closed by commit rG0ffad4ce5655: bhyve: Tidy lobits handling in pci_passthru (authored by jhb). · Explain WhyWed, Aug 26, 7:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0ffad4ce5655: bhyve: Tidy lobits handling in pci_passthru.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_passthru.c

7 lines

Diff 184209

View Options

usr.sbin/bhyve/pci_passthru.c

bhyve: Tidy lobits handling in pci_passthruClosedPublicActions