apple_bce: ignore duplicate TRANSFER_REQUEST in STATUS state
Needs ReviewPublic
Actions

Authored by seuros on Sun, Aug 16, 7:54 PM.

Tags

None

Referenced Files

	F167860213: D58873.diff
	Tue, Aug 25, 1:42 AM

	F167761876: D58873.diff
	Mon, Aug 24, 8:52 AM

	Unknown Object (File)
	Sat, Aug 22, 1:18 PM

	Unknown Object (File)
	Sat, Aug 22, 10:02 AM

	Unknown Object (File)
	Sat, Aug 22, 9:05 AM

	Unknown Object (File)
	Fri, Aug 21, 10:53 PM

	Unknown Object (File)
	Thu, Aug 20, 12:33 AM

	Unknown Object (File)
	Thu, Aug 20, 12:12 AM

View All 9 Files

Subscribers

imp

Details

Reviewers

adrian

Summary

Since the host initiates IN data transfers, the
firmware's own TRANSFER_REQUEST for the same phase arrives after
we've already moved to STATUS state. Ignoring instead of failing
the transfer with USB_ERR_IOERROR.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75628
Build 72511: arc lint + arc unit

Event Timeline

seuros created this revision.Sun, Aug 16, 7:54 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Aug 16, 7:54 PM

seuros requested review of this revision.Sun, Aug 16, 7:54 PM

Harbormaster completed remote builds in B75628: Diff 184139.Sun, Aug 16, 7:54 PM

seuros added a parent revision: D58872: apple_bce: initiate IN data phase for control transfers.Sun, Aug 16, 7:55 PM

seuros added a child revision: D58875: apple_bce: fix C_CONNECT_STATUS during port reset.Sun, Aug 16, 8:19 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

apple_bce/

apple_bce_vhci.c

5 lines

Diff 184139

View Options

sys/dev/apple_bce/apple_bce_vhci.c

apple_bce: ignore duplicate TRANSFER_REQUEST in STATUS stateNeeds ReviewPublicActions