Page MenuHomeFreeBSD
Differential D58870

apple_bce: kick USB explore thread after VHCI attach
ClosedPublic
Actions

Authored by seuros on Aug 16 2026, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 13, 11:57 PM
Unknown Object (File)
Sun, Sep 13, 12:58 PM
Unknown Object (File)
Mon, Sep 7, 3:00 AM
Unknown Object (File)
Sat, Sep 5, 8:13 PM
Unknown Object (File)
Thu, Sep 3, 2:16 PM
Unknown Object (File)
Thu, Sep 3, 6:47 AM
Unknown Object (File)
Thu, Sep 3, 3:03 AM
Unknown Object (File)
Thu, Sep 3, 3:03 AM
View All 28 Files
Subscribers
imp
ngie

Details

Reviewers
adrian
Commits
rGac5440ec248f: apple_bce: kick USB explore thread after VHCI attach
Summary

Call usb_needs_explore() after attach so the hub explore thread
enumerates all initially connected ports instead of only the first.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

seuros created this revision.Aug 16 2026, 6:39 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 16 2026, 6:39 PM
seuros requested review of this revision.Aug 16 2026, 6:39 PM
Harbormaster completed remote builds in B75625: Diff 184135.Aug 16 2026, 6:39 PM
seuros added a child revision: D58871: apple_bce: fix cold boot panic in mailbox send.Aug 16 2026, 7:55 PM
adrian accepted this revision.Sun, Sep 6, 5:17 PM
This revision is now accepted and ready to land.Sun, Sep 6, 5:17 PM
ngie added a subscriber: ngie.Sun, Sep 6, 6:49 PM

I just looked at the sources and I don't see any references to USB in the dependencies. Has this been properly accounted for?

seuros added a comment.Sun, Sep 6, 6:58 PM

It a dependency MODULE_DEPEND(bce_vhci, usb, 1, 1, 1); L254

ngie added a comment.Sun, Sep 6, 7:02 PM
In D58870#1364090, @ngie wrote:

I just looked at the sources and I don't see any references to USB in the dependencies. Has this been properly accounted for?

This is a separate item that needs to be resolved in the kernel configs.

Closed by commit rGac5440ec248f: apple_bce: kick USB explore thread after VHCI attach (authored by seuros). · Explain WhySun, Sep 6, 7:48 PM
This revision was automatically updated to reflect the committed changes.
seuros added a commit: rGac5440ec248f: apple_bce: kick USB explore thread after VHCI attach.

Revision Contents
Changeset List

PathSize
sys/
dev/
apple_bce/
6 lines

Diff 186025

View Options

sys/dev/apple_bce/apple_bce_vhci.c

Loading...