Page MenuHomeFreeBSD
Differential D58870

apple_bce: kick USB explore thread after VHCI attach
ClosedPublic
Actions

Authored by seuros on Aug 16 2026, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 17, 2:42 AM
Unknown Object (File)
Fri, Oct 16, 10:11 PM
Unknown Object (File)
Mon, Oct 12, 5:48 PM
Unknown Object (File)
Thu, Oct 8, 4:49 AM
Unknown Object (File)
Tue, Oct 6, 8:55 PM
Unknown Object (File)
Sun, Oct 4, 10:52 PM
Unknown Object (File)
Tue, Sep 29, 6:00 PM
Unknown Object (File)
Sat, Sep 26, 8:40 PM
View All 42 Files
Subscribers
imp
ngie

Details

Reviewers
adrian
Commits
rGac5440ec248f: apple_bce: kick USB explore thread after VHCI attach
Summary

Call usb_needs_explore() after attach so the hub explore thread
enumerates all initially connected ports instead of only the first.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 75625
Build 72508: arc lint + arc unit

Event Timeline

seuros created this revision.Aug 16 2026, 6:39 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 16 2026, 6:39 PM
seuros requested review of this revision.Aug 16 2026, 6:39 PM
Harbormaster completed remote builds in B75625: Diff 184135.Aug 16 2026, 6:39 PM
seuros added a child revision: D58871: apple_bce: fix cold boot panic in mailbox send.Aug 16 2026, 7:55 PM
adrian accepted this revision.Sep 6 2026, 5:17 PM
This revision is now accepted and ready to land.Sep 6 2026, 5:17 PM
ngie added a subscriber: ngie.Sep 6 2026, 6:49 PM

I just looked at the sources and I don't see any references to USB in the dependencies. Has this been properly accounted for?

seuros added a comment.Sep 6 2026, 6:58 PM

It a dependency MODULE_DEPEND(bce_vhci, usb, 1, 1, 1); L254

ngie added a comment.Sep 6 2026, 7:02 PM
In D58870#1364090, @ngie wrote:

I just looked at the sources and I don't see any references to USB in the dependencies. Has this been properly accounted for?

This is a separate item that needs to be resolved in the kernel configs.

Closed by commit rGac5440ec248f: apple_bce: kick USB explore thread after VHCI attach (authored by seuros). · Explain WhySep 6 2026, 7:48 PM
This revision was automatically updated to reflect the committed changes.
seuros added a commit: rGac5440ec248f: apple_bce: kick USB explore thread after VHCI attach.

Revision Contents
Changeset List

PathSize
sys/
dev/
apple_bce/
6 lines

Diff 184135

View Options

sys/dev/apple_bce/apple_bce_vhci.c

Loading...