nvme: limit visible namespaces on Apple S3X
ClosedPublic
Actions

Authored by seuros on Aug 14 2026, 3:48 PM.

Details

Reviewers

imp
adrian
ngie

Commits

rG417d6470cbd4: nvme: limit visible namespaces on Apple S3X

Summary

The Apple S3X controller exposes internal namespaces beyond NSID 1
that aren't meant to be visible to the OS. Added QUIRK_APPLE_S3X_NS1_ONLY
and nvme_ctrlr_num_namespaces()/nvme_ctrlr_nsid_visible() helpers, and
route namespace construction, notification, and AER namespace-changed
handling through them instead of a raw cdata.nn count.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75590
Build 72473: arc lint + arc unit

Event Timeline

seuros created this revision.Aug 14 2026, 3:48 PM

Herald added a subscriber: dab. · View Herald TranscriptAug 14 2026, 3:48 PM

seuros requested review of this revision.Aug 14 2026, 3:48 PM

Harbormaster completed remote builds in B75590: Diff 184054.Aug 14 2026, 3:48 PM

seuros added a parent revision: D58821: nvme: fix Apple S3X controller panic.Aug 14 2026, 3:50 PM

This looks good.
Sometimes I might have split the new quirk from the new behavior, but this case seems to be fine because (a) splitting it wouldn't help bisectability and (b) splitting wouldn't make it easier to review.

This revision is now accepted and ready to land.Aug 14 2026, 8:41 PM

I hope to get this code removed once we have MQS.

Disk Speed is ok, but it has the capability to be faster.

Closed by commit rG417d6470cbd4: nvme: limit visible namespaces on Apple S3X (authored by seuros, committed by adrian). · Explain WhyMon, Aug 24, 5:04 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG417d6470cbd4: nvme: limit visible namespaces on Apple S3X.