Page MenuHomeFreeBSD
Differential D6383

A10/A20 Security ID
ClosedPublic
Actions

Authored by manu on May 16 2016, 4:57 AM.
Tags
Referenced Files
Unknown Object (File)
Fri, Apr 19, 10:25 PM
Unknown Object (File)
Fri, Apr 19, 10:25 PM
Unknown Object (File)
Fri, Apr 19, 10:25 PM
Unknown Object (File)
Fri, Apr 19, 10:25 PM
Unknown Object (File)
Fri, Apr 19, 10:25 PM
Unknown Object (File)
Fri, Apr 19, 10:25 PM
Unknown Object (File)
Wed, Apr 17, 3:53 PM
Unknown Object (File)
Wed, Apr 17, 11:40 AM
View All Files
Subscribers
andrew
imp
jmcneill

Details

Reviewers
jmcneill
Group Reviewers
ARM
Commits
rS305440: MFC r303087
rS303087: Add support for the SID (Security ID Module) on Allwinner A10 and A20.
Summary

Add A10/A20 support for aw_sid.
Expose the rootkey via sysctl.
The rootkey can be used for product identification or to generate a mac address (this is was u-boot uses).

Test Plan

Tested on A10 and A20 hardware.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4497
Build 4549: arc lint + arc unit

Event Timeline

manu updated this revision to Diff 16367.May 16 2016, 4:57 AM
manu retitled this revision from to A10/A20 Security ID.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added a reviewer: ARM.
manu set the repository for this revision to rS FreeBSD src repository - subversion.
manu added a project: ARM.
Herald added subscribers: andrew, imp. · View Herald TranscriptMay 16 2016, 4:57 AM
jmcneill added a subscriber: jmcneill.Jul 11 2016, 8:59 AM
jmcneill added inline comments.
sys/arm/allwinner/aw_sid.c
120

Can you make this based on compat string instead?

166

be32enc(&out[i * 4], tmp);

185

I would change == ENXIO to != 0.

andrew added inline comments.Jul 11 2016, 9:24 AM
sys/arm/allwinner/aw_sid.c
188

I think you can use %D here. It's part of printf(9).

manu added inline comments.Jul 12 2016, 7:15 AM
sys/arm/allwinner/aw_sid.c
188

%D gives me the decimal representation.
Also quoting the man :
These conversion characters are deprecated, and will eventually disappear.

manu updated this revision to Diff 18337.Jul 12 2016, 6:20 PM

Update based on comment from jmcneill

manu marked 5 inline comments as done.Jul 12 2016, 6:20 PM
andrew added inline comments.Jul 12 2016, 6:34 PM
sys/arm/allwinner/aw_sid.c
188

The libc printf will print a decimal representation, however the kernel printf will print a hexdump of a string. It is also not listed as being deprecated in the man page.

https://www.freebsd.org/cgi/man.cgi?query=printf&sektion=9

manu updated this revision to Diff 18338.Jul 12 2016, 6:54 PM

Use printf(9) %D conversion char.

manu marked an inline comment as done.Jul 12 2016, 6:54 PM
jmcneill added inline comments.Jul 13 2016, 7:07 AM
sys/arm/allwinner/aw_sid.c
163

Should return an error here if this gets called on something other than A10/A20.

manu updated this revision to Diff 18378.Jul 13 2016, 12:05 PM
Return ENXIO if rootkey is called on a SoC != A10 and A20
Return ENXIO if tscalib is called on a SoC != A83T
manu marked an inline comment as done.Jul 13 2016, 12:05 PM
jmcneill accepted this revision.Jul 19 2016, 8:40 PM
jmcneill added a reviewer: jmcneill.
This revision is now accepted and ready to land.Jul 19 2016, 8:40 PM
Closed by commit rS303087: Add support for the SID (Security ID Module) on Allwinner A10 and A20. (authored by manu). · Explain WhyJul 20 2016, 11:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm/
allwinner/
1 line
77 lines

Diff 18378

View Options

sys/arm/allwinner/aw_sid.h

Loading...
View Options

sys/arm/allwinner/aw_sid.c

Loading...