A10/A20 Security ID

[manu]

Summary

Add A10/A20 support for aw_sid.
Expose the rootkey via sysctl.
The rootkey can be used for product identification or to generate a mac address (this is was u-boot uses).

Test Plan

Tested on A10 and A20 hardware.

[jmcneill]

sys/arm/allwinner/aw_sid.c

119

Can you make this based on compat string instead?

162

be32enc(&out[i * 4], tmp);

181

I would change == ENXIO to != 0.

[andrew]

sys/arm/allwinner/aw_sid.c

184

I think you can use %D here. It's part of printf(9).

[manu]

sys/arm/allwinner/aw_sid.c

184

%D gives me the decimal representation.
Also quoting the man :
These conversion characters are deprecated, and will eventually disappear.

[manu]

Update based on comment from jmcneill

[andrew]

sys/arm/allwinner/aw_sid.c

184

The libc printf will print a decimal representation, however the kernel printf will print a hexdump of a string. It is also not listed as being deprecated in the man page.

https://www.freebsd.org/cgi/man.cgi?query=printf&sektion=9

[manu]

Use printf(9) %D conversion char.

[jmcneill]

sys/arm/allwinner/aw_sid.c

159

Should return an error here if this gets called on something other than A10/A20.

[manu]

Return ENXIO if rootkey is called on a SoC != A10 and A20
Return ENXIO if tscalib is called on a SoC != A83T