Page MenuHomeFreeBSD
Differential D7195

hyperv/stor: Refactor storvsc by applying BUS_DMA for CAM_DATA_BIO
ClosedPublic
Actions

Authored by honzhan_microsoft.com on Jul 12 2016, 8:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 9, 11:04 AM
Unknown Object (File)
Mon, May 6, 4:16 PM
Unknown Object (File)
Sun, May 5, 8:02 PM
Unknown Object (File)
Sun, May 5, 12:19 PM
Unknown Object (File)
Sun, May 5, 2:27 AM
Unknown Object (File)
Thu, May 2, 11:25 AM
Unknown Object (File)
Wed, May 1, 11:36 PM
Unknown Object (File)
Sat, Apr 27, 5:09 AM
View All 87 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
howard0su_gmail.com
decui_microsoft.com
hrs
delphij
sepherosa_gmail.com
Commits
rS303474: hyperv/storvsc: Use busdma(9) and enable PIM_UNMAPPED by default.
Summary

This fix targets to clean the storage code with BUS_DMA interface.
In addition, this can improve the performance 1.35X ~ 2.35x for FIO on hyperv.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

honzhan_microsoft.com updated this revision to Diff 18324.Jul 12 2016, 8:38 AM
honzhan_microsoft.com retitled this revision from to hyperv/stor: Refactor storvsc by applying BUS_DMA for CAM_DATA_BIO.
honzhan_microsoft.com updated this object.
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJul 12 2016, 8:38 AM
honzhan_microsoft.com updated this revision to Diff 18328.Jul 12 2016, 9:02 AM
honzhan_microsoft.com removed rS FreeBSD src repository - subversion as the repository for this revision.
honzhan_microsoft.com updated this object.Jul 12 2016, 9:05 AM
honzhan_microsoft.com added reviewers: sepherosa_gmail.com, delphij, decui_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com accepted this revision.Jul 12 2016, 9:20 AM
sepherosa_gmail.com edited edge metadata.

Look fine. Some minors.

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
1053

Destroy the map; though it should be no-op in this case. And the maps could also be destroyed on storvsc_detach path.

1931

Pass BUS_DMA_NOWAIT as the flag, since the code here assumes the direct running of the callback. And check the return value of bus_dmamap_load_ccb, even though it should not fail here, since no bounce pages will be needed; better safe than sorry.

This revision is now accepted and ready to land.Jul 12 2016, 9:20 AM
honzhan_microsoft.com updated this revision to Diff 18355.Jul 13 2016, 5:02 AM
honzhan_microsoft.com edited edge metadata.
This revision now requires review to proceed.Jul 13 2016, 5:02 AM
honzhan_microsoft.com updated this revision to Diff 18365.Jul 13 2016, 6:24 AM
honzhan_microsoft.com edited edge metadata.
honzhan_microsoft.com added a reviewer: hrs.Jul 13 2016, 7:56 AM
sepherosa_gmail.com accepted this revision.Jul 13 2016, 8:42 AM
sepherosa_gmail.com edited edge metadata.

Looks good

This revision is now accepted and ready to land.Jul 13 2016, 8:42 AM
Closed by commit rS303474: hyperv/storvsc: Use busdma(9) and enable PIM_UNMAPPED by default. (authored by sephe). · Explain WhyJul 29 2016, 6:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
storvsc/
226 lines

Diff 18365

View Options

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

Loading...