Page MenuHomeFreeBSD
Differential D58672

rtadvd: Fix RA flag inconsistency messages
ClosedPublic
Actions

Authored by pouria on Wed, Aug 5, 8:52 AM.
Tags
None
Referenced Files
F169789404: D58672.id183440.diff
Wed, Sep 2, 2:00 PM
Unknown Object (File)
Wed, Sep 2, 3:12 AM
Unknown Object (File)
Tue, Sep 1, 11:28 PM
Unknown Object (File)
Tue, Sep 1, 9:05 PM
Unknown Object (File)
Tue, Sep 1, 8:03 PM
Unknown Object (File)
Tue, Sep 1, 4:56 PM
Unknown Object (File)
Tue, Sep 1, 2:22 PM
Unknown Object (File)
Tue, Sep 1, 12:58 PM
View All 87 Files
Subscribers
imp

Details

Reviewers
glebius
markj
kfv
Group Reviewers
network
Commits
rGb3e20e1a0386: rtadvd(8): Fix RA flag inconsistency messages
rGc3a70b0319d9: rtadvd(8): Fix RA flag inconsistency messages
rG200de1b70e2b: rtadvd(8): Fix RA flag inconsistency messages
Summary

During flag inconsistency report, we handle rai->rai_otherflg
as a bool, but the value is 0x40. Make it a simple number comparison.

PR: 295995

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75390
Build 72273: arc lint + arc unit

Event Timeline

pouria created this revision.Wed, Aug 5, 8:52 AM
pouria held this revision as a draft.
Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 5, 8:52 AM
Harbormaster completed remote builds in B75390: Diff 183436.Wed, Aug 5, 8:52 AM
kfv added inline comments.Wed, Aug 5, 12:55 PM
usr.sbin/rtadvd/rtadvd.c
1143
1154
pouria updated this revision to Diff 183440.Wed, Aug 5, 2:21 PM
pouria marked 2 inline comments as done.

Address @kfv_kfv.io comment. What an aweful mistake :D. Now it should be ready to review. Thanks!

Harbormaster completed remote builds in B75391: Diff 183440.Wed, Aug 5, 2:21 PM
pouria published this revision for review.Wed, Aug 5, 2:22 PM
markj accepted this revision.Wed, Aug 5, 2:24 PM
markj added inline comments.
usr.sbin/rtadvd/rtadvd.c
1141

No need for parentheses here or below.

This revision is now accepted and ready to land.Wed, Aug 5, 2:24 PM
pouria updated this revision to Diff 183441.Wed, Aug 5, 2:27 PM

Address @markj comment.

This revision now requires review to proceed.Wed, Aug 5, 2:27 PM
Harbormaster completed remote builds in B75392: Diff 183441.Wed, Aug 5, 2:27 PM
pouria marked an inline comment as done.Wed, Aug 5, 2:28 PM
kfv accepted this revision.Wed, Aug 5, 2:32 PM
This revision is now accepted and ready to land.Wed, Aug 5, 2:32 PM
markj accepted this revision.Wed, Aug 5, 2:34 PM
Closed by commit rG200de1b70e2b: rtadvd(8): Fix RA flag inconsistency messages (authored by pouria). · Explain WhyWed, Aug 5, 3:22 PM
This revision was automatically updated to reflect the committed changes.
pouria added a commit: rG200de1b70e2b: rtadvd(8): Fix RA flag inconsistency messages.
pouria added a commit: rGc3a70b0319d9: rtadvd(8): Fix RA flag inconsistency messages.Sat, Aug 8, 6:17 AM
pouria added a commit: rGb3e20e1a0386: rtadvd(8): Fix RA flag inconsistency messages.Sat, Aug 8, 6:21 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
rtadvd/
8 lines

Diff 183436

View Options

usr.sbin/rtadvd/rtadvd.c

Loading...