if_bnxt: rework interrupt coalescing onto the AGGINT_QCAPS scheme
Needs ReviewPublic
Actions

Authored by sumit.saxena_broadcom.com on Mon, Aug 3, 1:12 PM.

Details

Reviewers

chandrakanth.patil_broadcom.com
sreekanth.reddy_broadcom.com
gallatin
shurd

Summary

Query firmware-advertised coalescing capabilities and program
per-direction rx/tx coalescing settings against them, replacing the
old hardcoded scheme. Add sysctls for the coalescing mode, budget,
and stats-timer knobs the new scheme exposes.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sumit.saxena_broadcom.com created this revision.Mon, Aug 3, 1:12 PM

Herald added a reviewer: shurd. · View Herald TranscriptMon, Aug 3, 1:12 PM

sumit.saxena_broadcom.com requested review of this revision.Mon, Aug 3, 1:12 PM

sumit.saxena_broadcom.com updated this revision to Diff 183302.Mon, Aug 3, 2:00 PM

gallatin added inline comments.Tue, Aug 4, 8:45 PM

sys/dev/bnxt/bnxt_en/bnxt_hwrm.c
3366	I think you need to explicitly take the hwrm lock and call the _hwrm_send_message() variant. As far as I can see, the resp is shared among commands and zeroed at every use, so once you drop the lock (which hwrm_send_message() does before return), the response could be zeroed or for somebody else's command.