libc: getopt{,_long}: Const correctness for C23
ClosedPublic
Actions

Authored by ivy on Mon, Jul 27, 10:31 PM.

Details

Reviewers

imp
arichardson
emaste
des
kevans

Commits

rGf1d98862044f: libc: getopt{,_long}: Const correctness for C23

Summary

On some platforms, e.g. Linux Clang 22.1.8 / glibc 2.43, strchr()
now implements the C23 behaviour where passing a const pointer to
strchr() also returns a const pointer. This breaks getopt during
the bootstrap build, since it assumes the return value is always
a mutable pointer.

Since the pointed-to value is never modified, fix this by making
the pointer const.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75182
Build 72065: arc lint + arc unit

Event Timeline

ivy requested review of this revision.Mon, Jul 27, 10:31 PM

ivy created this revision.

Harbormaster completed remote builds in B75182: Diff 182842.Mon, Jul 27, 10:31 PM

ivy retitled this revision from libc: getopt{,_long}: const correctness for C23 to libc: getopt{,_long}: Const correctness for C23.Mon, Jul 27, 11:16 PM

emaste accepted this revision.Tue, Jul 28, 12:29 AM

This revision is now accepted and ready to land.Tue, Jul 28, 12:29 AM

Closed by commit rGf1d98862044f: libc: getopt{,_long}: Const correctness for C23 (authored by ivy). · Explain WhyMon, Aug 3, 2:30 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rGf1d98862044f: libc: getopt{,_long}: Const correctness for C23.