Page MenuHomeFreeBSD
Differential D58307

firewire: add warn-only CRC validation for CSR ROM directories
ClosedPublic
Actions

Authored by guest-seuros on Fri, Jul 17, 4:39 PM.
Tags
Referenced Files
F165357122: D58307.diff
Fri, Aug 7, 7:49 PM
F165259940: D58307.diff
Fri, Aug 7, 6:05 AM
Unknown Object (File)
Tue, Aug 4, 8:20 AM
Unknown Object (File)
Fri, Jul 31, 8:05 AM
Unknown Object (File)
Thu, Jul 30, 6:37 PM
Unknown Object (File)
Thu, Jul 30, 4:02 PM
Unknown Object (File)
Thu, Jul 30, 5:16 AM
Unknown Object (File)
Sat, Jul 25, 7:08 PM
View All 30 Files
Subscribers
imp

Details

Reviewers
adrian
Group Reviewers
firewire
Commits
rGd3259935f778: firewire: add warn-only CRC validation for CSR ROM directories
Summary

Implemented crom_crc_valid() helper to validate IEEE 1394 config ROM CRC-16
checksums.

Skipped root header CRC validation since csrhdr.crc_len cover the entire
ROM body which is not fully read at header parse time. Per-directory
CRC checks below catch corruption where it needed.

Test Plan

adrian

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74891
Build 71774: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
dev/
firewire/
15 lines
5 lines
7 lines
5 lines
1 line

Diff 182144

View Options

sys/dev/firewire/firewire.c

Loading...
View Options

sys/dev/firewire/fwcam.c

Loading...
View Options

sys/dev/firewire/fwcrom.c

Loading...
View Options

sys/dev/firewire/fwisound.c

Loading...
View Options

sys/dev/firewire/iec13213.h

Loading...