Page MenuHomeFreeBSD
Differential D58307

firewire: add warn-only CRC validation for CSR ROM directories
ClosedPublic
Actions

Authored by seuros on Jul 17 2026, 4:39 PM.
Tags
Referenced Files
Unknown Object (File)
Mon, Oct 12, 1:48 AM
Unknown Object (File)
Tue, Oct 6, 9:12 PM
Unknown Object (File)
Sun, Oct 4, 2:08 PM
Unknown Object (File)
Sun, Oct 4, 1:33 AM
Unknown Object (File)
Sun, Oct 4, 1:14 AM
Unknown Object (File)
Sun, Oct 4, 12:38 AM
Unknown Object (File)
Wed, Sep 30, 6:30 PM
Unknown Object (File)
Sat, Sep 26, 9:12 PM
View All 65 Files
Subscribers
imp

Details

Reviewers
adrian
Group Reviewers
firewire
Commits
rGd3259935f778: firewire: add warn-only CRC validation for CSR ROM directories
Summary

Implemented crom_crc_valid() helper to validate IEEE 1394 config ROM CRC-16
checksums.

Skipped root header CRC validation since csrhdr.crc_len cover the entire
ROM body which is not fully read at header parse time. Per-directory
CRC checks below catch corruption where it needed.

Test Plan

adrian

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74891
Build 71774: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
dev/
firewire/
15 lines
5 lines
7 lines
5 lines
1 line

Diff 182144

View Options

sys/dev/firewire/firewire.c

Loading...
View Options

sys/dev/firewire/fwcam.c

Loading...
View Options

sys/dev/firewire/fwcrom.c

Loading...
View Options

sys/dev/firewire/fwisound.c

Loading...
View Options

sys/dev/firewire/iec13213.h

Loading...