Page MenuHomeFreeBSD
Differential D58201

firewire: per-unit-directory child device support
ClosedPublic
Actions

Authored by guest-seuros on Sun, Jul 12, 8:58 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Jul 22, 6:03 PM
Unknown Object (File)
Wed, Jul 22, 8:12 AM
Unknown Object (File)
Tue, Jul 21, 7:00 AM
Unknown Object (File)
Tue, Jul 21, 5:09 AM
Unknown Object (File)
Tue, Jul 21, 5:05 AM
Unknown Object (File)
Tue, Jul 21, 3:02 AM
Unknown Object (File)
Tue, Jul 21, 3:00 AM
Unknown Object (File)
Tue, Jul 21, 12:46 AM
View All 26 Files
Subscribers
imp
ziaee

Details

Reviewers
adrian
Group Reviewers
firewire
Commits
rG21143476a576: firewire: per-unit-directory child device support
Summary

Added structure to allow multiple device to attach to the same driver.
Also removed the deprecation warning from the man page.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74756
Build 71639: arc lint + arc unit

Event Timeline

guest-seuros created this revision.Sun, Jul 12, 8:58 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptSun, Jul 12, 8:58 PM
guest-seuros requested review of this revision.Sun, Jul 12, 8:58 PM
Harbormaster completed remote builds in B74756: Diff 181857.Sun, Jul 12, 8:58 PM
guest-seuros added a child revision: D58202: fwcam: match unit directories, defer probe to first open.Sun, Jul 12, 9:03 PM
guest-seuros added a child revision: D58203: fwisound: match unit directories instead of IDENTIFY.Sun, Jul 12, 9:12 PM
guest-seuros added a reviewer: firewire.
guest-seuros added projects: firewire, drivers.
guest-seuros added a child revision: D58204: fwdv: match unit directories instead of IDENTIFY.Sun, Jul 12, 9:16 PM
guest-seuros removed a child revision: D58203: fwisound: match unit directories instead of IDENTIFY.Sun, Jul 12, 9:18 PM
guest-seuros removed a child revision: D58204: fwdv: match unit directories instead of IDENTIFY.
adrian added inline comments.Sun, Jul 12, 10:26 PM
share/man/man4/firewire.4
52

we cant remove this yet; the last thing to kill is any leftover GIANT usage.

adrian added inline comments.Mon, Jul 13, 2:20 AM
share/man/man4/firewire.4
52

my bad; we need to remove the spl references and audit behaviour.

remove this from the diff for now; lets get these diffs in and then remove spl and then ill put in the request to srcmgr@ .

guest-seuros added inline comments.Mon, Jul 13, 9:55 AM
share/man/man4/firewire.4
52

SPL removal was trivial and i did remove it when i started work of firewire as the code seems to do nothing. I added the removal in the stack .

guest-seuros updated this revision to Diff 182051.Wed, Jul 15, 7:34 PM

restore deprecation

Harbormaster completed remote builds in B74834: Diff 182051.Wed, Jul 15, 7:34 PM
adrian accepted this revision.Fri, Jul 17, 4:05 AM

yes i tested this!

This revision is now accepted and ready to land.Fri, Jul 17, 4:05 AM
Closed by commit rG21143476a576: firewire: per-unit-directory child device support (authored by guest-seuros, committed by adrian). · Explain WhyFri, Jul 17, 4:09 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG21143476a576: firewire: per-unit-directory child device support.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
31 lines
sys/
dev/
firewire/
229 lines
53 lines
8 lines
8 lines
5 lines
8 lines

Diff 181857

View Options

share/man/man4/firewire.4

Loading...
View Options

sys/dev/firewire/firewire.c

Loading...
View Options

sys/dev/firewire/firewirereg.h

Loading...
View Options

sys/dev/firewire/if_fwe.c

Loading...
View Options

sys/dev/firewire/if_fwip.c

Loading...
View Options

sys/dev/firewire/sbp.c

Loading...
View Options

sys/dev/firewire/sbp_targ.c

Loading...