Page MenuHomeFreeBSD
Differential D58201

firewire: per-unit-directory child device support
ClosedPublic
Actions

Authored by seuros on Jul 12 2026, 8:58 PM.
Tags
Referenced Files
F167831216: D58201.diff
Mon, Aug 24, 8:33 PM
Unknown Object (File)
Sun, Aug 23, 12:17 AM
Unknown Object (File)
Tue, Aug 18, 5:12 AM
Unknown Object (File)
Sat, Aug 8, 4:23 PM
Unknown Object (File)
Sat, Aug 8, 4:18 PM
Unknown Object (File)
Sat, Aug 8, 10:51 AM
Unknown Object (File)
Fri, Aug 7, 6:07 AM
Unknown Object (File)
Fri, Aug 7, 6:07 AM
View All 48 Files
Subscribers
imp
ziaee

Details

Reviewers
adrian
Group Reviewers
firewire
Commits
rG21143476a576: firewire: per-unit-directory child device support
Summary

Added structure to allow multiple device to attach to the same driver.
Also removed the deprecation warning from the man page.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

seuros created this revision.Jul 12 2026, 8:58 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptJul 12 2026, 8:58 PM
seuros requested review of this revision.Jul 12 2026, 8:58 PM
Harbormaster completed remote builds in B74756: Diff 181857.Jul 12 2026, 8:58 PM
seuros added a child revision: D58202: fwcam: match unit directories, defer probe to first open.Jul 12 2026, 9:03 PM
seuros added a child revision: D58203: fwisound: match unit directories instead of IDENTIFY.Jul 12 2026, 9:12 PM
seuros added a reviewer: firewire.
seuros added projects: firewire, drivers.
seuros added a child revision: D58204: fwdv: match unit directories instead of IDENTIFY.Jul 12 2026, 9:16 PM
seuros removed a child revision: D58203: fwisound: match unit directories instead of IDENTIFY.Jul 12 2026, 9:18 PM
seuros removed a child revision: D58204: fwdv: match unit directories instead of IDENTIFY.
adrian added inline comments.Jul 12 2026, 10:26 PM
share/man/man4/firewire.4
52

we cant remove this yet; the last thing to kill is any leftover GIANT usage.

adrian added inline comments.Jul 13 2026, 2:20 AM
share/man/man4/firewire.4
52

my bad; we need to remove the spl references and audit behaviour.

remove this from the diff for now; lets get these diffs in and then remove spl and then ill put in the request to srcmgr@ .

seuros added inline comments.Jul 13 2026, 9:55 AM
share/man/man4/firewire.4
52

SPL removal was trivial and i did remove it when i started work of firewire as the code seems to do nothing. I added the removal in the stack .

seuros updated this revision to Diff 182051.Jul 15 2026, 7:34 PM

restore deprecation

Harbormaster completed remote builds in B74834: Diff 182051.Jul 15 2026, 7:34 PM
adrian accepted this revision.Jul 17 2026, 4:05 AM

yes i tested this!

This revision is now accepted and ready to land.Jul 17 2026, 4:05 AM
Closed by commit rG21143476a576: firewire: per-unit-directory child device support (authored by seuros, committed by adrian). · Explain WhyJul 17 2026, 4:09 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG21143476a576: firewire: per-unit-directory child device support.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
26 lines
sys/
dev/
firewire/
229 lines
53 lines
8 lines
8 lines
5 lines
8 lines

Diff 182101

View Options

share/man/man4/firewire.4

Loading...
View Options

sys/dev/firewire/firewire.c

Loading...
View Options

sys/dev/firewire/firewirereg.h

Loading...
View Options

sys/dev/firewire/if_fwe.c

Loading...
View Options

sys/dev/firewire/if_fwip.c

Loading...
View Options

sys/dev/firewire/sbp.c

Loading...
View Options

sys/dev/firewire/sbp_targ.c

Loading...