Page MenuHomeFreeBSD
Differential D58038

ps.1: Fix broken comment line
ClosedPublic
Actions

Authored by temcbun_gmail.com on Sat, Jul 4, 3:32 PM.
Tags
Referenced Files
F162160877: D58038.diff
Fri, Jul 10, 10:46 AM
F162160378: D58038.diff
Fri, Jul 10, 10:38 AM
Unknown Object (File)
Wed, Jul 8, 10:53 PM
Unknown Object (File)
Wed, Jul 8, 10:41 PM
Unknown Object (File)
Wed, Jul 8, 10:41 PM
Unknown Object (File)
Tue, Jul 7, 4:18 AM
Unknown Object (File)
Mon, Jul 6, 3:26 AM
Unknown Object (File)
Sun, Jul 5, 7:00 PM
View All 10 Files
Subscribers
imp

Details

Reviewers
ziaee
olce
Group Reviewers
docs
manpages
Commits
rG759ce9a2b38e: ps.1: Fix broken comment line
Summary

It was visually displayed as an extra empty line before the NAME section.

Fixes: ddf144a04b53 ("ps.1: Revamp: Explain general principles, update to match reality")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

temcbun_gmail.com created this revision.Sat, Jul 4, 3:32 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Jul 4, 3:32 PM
temcbun_gmail.com requested review of this revision.Sat, Jul 4, 3:32 PM
ziaee accepted this revision.Sat, Jul 4, 6:43 PM
ziaee removed a reviewer: Contributor Reviews (src).
ziaee added inline comments.
bin/ps/ps.1
1

While we're here

This revision is now accepted and ready to land.Sat, Jul 4, 6:43 PM
temcbun_gmail.com updated this revision to Diff 181293.Sat, Jul 4, 6:46 PM

Remove hyphen from the first comment line. Thanks @ziaee!

This revision now requires review to proceed.Sat, Jul 4, 6:46 PM
olce accepted this revision.Sun, Jul 5, 4:49 PM

Removing the hyphen in the first line is fine, but then that should be mentioned in the commit message. I can add a sentence to that effect myself. Which mail do you want to use? The one that can be inferred from your Phabricator login? I also see a mail at "zohomail" in the tree that could match. If you have to disclose the full name and don't want to do that here, then please mail it to me (olce@).

This revision is now accepted and ready to land.Sun, Jul 5, 4:49 PM
temcbun_gmail.com added a comment.Sun, Jul 5, 4:53 PM
In D58038#1331015, @olce wrote:

Removing the hyphen in the first line is fine, but then that should be mentioned in the commit message. I can add a sentence to that effect myself.

Sure, thanks.

Which mail do you want to use?

A gmail one - temcbun@gmail.com.

Closed by commit rG759ce9a2b38e: ps.1: Fix broken comment line (authored by temcbun_gmail.com, committed by olce). · Explain WhySun, Jul 5, 8:04 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG759ce9a2b38e: ps.1: Fix broken comment line.

Revision Contents
Changeset List

PathSize
bin/
ps/
4 lines

Diff 181293

View Options

bin/ps/ps.1

Loading...