ps.1: Fix broken comment line
ClosedPublic
Actions

Authored by temcbun_gmail.com on Sat, Jul 4, 3:32 PM.

Details

Reviewers

ziaee
olce

Group Reviewers

docs
manpages

Commits

rG952eb3db7f5c: ps.1: Fix broken comment line
rGafd579619956: ps.1: Fix broken comment line
rG759ce9a2b38e: ps.1: Fix broken comment line

Summary

It was visually displayed as an extra empty line before the NAME section.

Fixes: ddf144a04b53 ("ps.1: Revamp: Explain general principles, update to match reality")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

temcbun_gmail.com created this revision.Sat, Jul 4, 3:32 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Jul 4, 3:32 PM

temcbun_gmail.com requested review of this revision.Sat, Jul 4, 3:32 PM

ziaee accepted this revision.Sat, Jul 4, 6:43 PM

ziaee removed a reviewer: Contributor Reviews (src).

ziaee added inline comments.

bin/ps/ps.1
1	While we're here

This revision is now accepted and ready to land.Sat, Jul 4, 6:43 PM

Remove hyphen from the first comment line. Thanks @ziaee!

This revision now requires review to proceed.Sat, Jul 4, 6:46 PM

Removing the hyphen in the first line is fine, but then that should be mentioned in the commit message. I can add a sentence to that effect myself. Which mail do you want to use? The one that can be inferred from your Phabricator login? I also see a mail at "zohomail" in the tree that could match. If you have to disclose the full name and don't want to do that here, then please mail it to me (olce@).

This revision is now accepted and ready to land.Sun, Jul 5, 4:49 PM

In D58038#1331015, @olce wrote:

Removing the hyphen in the first line is fine, but then that should be mentioned in the commit message. I can add a sentence to that effect myself.

Sure, thanks.