Page MenuHomeFreeBSD

pkg/FreeBSD.confs: Improve comment wrapping
Needs ReviewPublic

Authored by ziaee on Mon, Jun 29, 3:55 AM.
Tags
None
Referenced Files
F161275785: D57936.diff
Thu, Jul 2, 8:55 AM
F161275783: D57936.diff
Thu, Jul 2, 8:55 AM
F161275779: D57936.diff
Thu, Jul 2, 8:55 AM
F161275776: D57936.diff
Thu, Jul 2, 8:55 AM
F161275774: D57936.diff
Thu, Jul 2, 8:55 AM
F161275751: D57936.diff
Thu, Jul 2, 8:55 AM
F161275737: D57936.diff
Thu, Jul 2, 8:55 AM
F161275717: D57936.diff
Thu, Jul 2, 8:55 AM
Subscribers

Details

Reviewers
bapt
cperciva
bdrewery
Group Reviewers
pkgbase
Summary

cd into the directory first before writing to the files in the examples,
this increases consistency with the rest of the configuration files in
the base system, which are all wrapped before 72, except for some bolted
on lines here and there.

Unresolved: Should that blank line be there at the start of quarterly
config? The others do not have it but, chestertons fence and all.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74373
Build 71256: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Mon, Jun 29, 3:55 AM

this makes the sample commands more difficult to copy and paste for no clear benefit. i'm not sure this is an improvement.

In D57936#1328645, @ivy wrote:

this makes the sample commands more difficult to copy and paste for no clear benefit. i'm not sure this is an improvement.

I am inclined to agree with @ivy here.. With the comments it means an extra copy/paste step.