We try hard to not have magic numbers in drivers, find/create a _var.h or _reg.h to put the firmware/register values like this into.
(And then we can also add documentation about what we've figured out what the values mean, eg what "battery-cuv" means :-) )

This is just a temporary mapping not the final form of the driver.

Some values here gathered from Wikis and online knowledge.

The Values that are 100% tested are extracted to sys/dev/asmc/asmcvar.h ...

I still need to update the man pages once the code is tested for a while.

This can fail/return NULL. That case should be handled gracefully.

This is just a temporary mapping not the final form of the driver.

Some values here gathered from Wikis and online knowledge.

The Values that are 100% tested are extracted to sys/dev/asmc/asmcvar.h ...

I still need to update the man pages once the code is tested for a while.

Could you please create a struct for this for clarity, e.g., struct asmc_event_t { int code; const char *description; }, and have a separate function/macro like this, e.g., asmc_event_description? If you do that, then all you need to do is define these things in an array then loop through to map the descriptions to the codes.

Why 48? Magic numbers should be self-describing constants.

Why 48?

Please avoid hardcoding lengths (this is just one example).

Could you please describe what the acronyms mean in more detail, even if it's just in a comment?

Why EIO?

Why 8/9?

This can fail/return NULL. That case should be handled gracefully.

yeah, and *sigh* lots of other drivers don't even bother to check either. :(

But yeah, @guest-seuros let's at least print an error and return if it's NULL, just to show we can do it better-er.

yes.

cuz 47 is copyrighted by AI. 😆

Seriously, just headroom for the longest string possible. 38 is the max, i added 10 just to be on a safe side.

EIO is the correct error here.

The key existence was already verified during attach with asmc_key_getinfo(). If asmc_key_read fails later, it because the SMC transaction itself failed (timeout, NACK, bus error, or an SMC reset after attach).

Personally, i named this event as the SMC is pleading the Fifth and something fatal happened. 😆

8 = SMC key data length, 9 = +1 for NULL terminator. example "Mac-XXXX".