Paths

Table of Contentst

rack_bbr_common: Stale eh pointer used after m_adj() and m_pullup()
ClosedPublic
Actions

Authored by thebugfixers_pm.me on Wed, Jun 24, 1:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jul 5, 6:34 PM

	Unknown Object (File)
	Sun, Jul 5, 6:30 PM

	Unknown Object (File)
	Sun, Jul 5, 7:33 AM

	Unknown Object (File)
	Sun, Jul 5, 6:50 AM

	Unknown Object (File)
	Sun, Jul 5, 6:28 AM

	Unknown Object (File)
	Sat, Jul 4, 10:30 PM

	Unknown Object (File)
	Sat, Jul 4, 1:26 PM

	Unknown Object (File)
	Sat, Jul 4, 1:23 PM

Subscribers

Details

Reviewers

tuexen

Group Reviewers

Src Committers
Contributor Reviews (src)
transport

Commits

rGbe23edc1e402: rack_bbr_common: don't use stale pointer after m_pullup()

Summary

Replace use of eh after m_adj() with mtod(m, struct ip6_hdr *) and mtod(m, struct ip *)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

thebugfixers_pm.me created this revision.Wed, Jun 24, 1:16 PM

Herald added a reviewer: transport. · View Herald TranscriptWed, Jun 24, 1:16 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

thebugfixers_pm.me requested review of this revision.Wed, Jun 24, 1:16 PM

thebugfixers_pm.me added a child revision: D57817: rack_bbr_common: uninitialized *ret_val in ctf_drop_checks().Fri, Jun 26, 5:26 PM

Good catch!

This revision is now accepted and ready to land.Sun, Jun 28, 11:01 AM

Closed by commit rGbe23edc1e402: rack_bbr_common: don't use stale pointer after m_pullup() (authored by thebugfixers_pm.me, committed by tuexen). · Explain WhySun, Jun 28, 11:08 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGbe23edc1e402: rack_bbr_common: don't use stale pointer after m_pullup().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack_bbr_common.c

4 lines

Diff 180527

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

rack_bbr_common: Stale eh pointer used after m_adj() and m_pullup()ClosedPublicActions