rack_bbr_common: Stale eh pointer used after m_adj() and m_pullup()
ClosedPublic
Actions

Authored by thebugfixers_pm.me on Jun 24 2026, 1:16 PM.

Details

Reviewers

Group Reviewers

Src Committers
Contributor Reviews (src)
transport

Commits

rGa5423ccd1c26: rack_bbr_common: don't use stale pointer after m_pullup()
rG1cd388ddf0d3: rack_bbr_common: don't use stale pointer after m_pullup()
rGbe23edc1e402: rack_bbr_common: don't use stale pointer after m_pullup()

Summary

Replace use of eh after m_adj() with mtod(m, struct ip6_hdr *) and mtod(m, struct ip *)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

thebugfixers_pm.me created this revision.Jun 24 2026, 1:16 PM

Herald added a reviewer: transport. · View Herald TranscriptJun 24 2026, 1:16 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

thebugfixers_pm.me requested review of this revision.Jun 24 2026, 1:16 PM

thebugfixers_pm.me added a child revision: D57817: rack_bbr_common: uninitialized *ret_val in ctf_drop_checks().Jun 26 2026, 5:26 PM

Good catch!

This revision is now accepted and ready to land.Jun 28 2026, 11:01 AM

Closed by commit rGbe23edc1e402: rack_bbr_common: don't use stale pointer after m_pullup() (authored by thebugfixers_pm.me, committed by tuexen). · Explain WhyJun 28 2026, 11:08 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGbe23edc1e402: rack_bbr_common: don't use stale pointer after m_pullup().

tuexen added a commit: rG1cd388ddf0d3: rack_bbr_common: don't use stale pointer after m_pullup().Thu, Aug 6, 8:23 AM

tuexen added a commit: rGa5423ccd1c26: rack_bbr_common: don't use stale pointer after m_pullup().Thu, Aug 6, 9:05 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack_bbr_common.c

4 lines

Diff 180870

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

rack_bbr_common: Stale eh pointer used after m_adj() and m_pullup()ClosedPublicActions