Page MenuHomeFreeBSD
Differential D57283

ctld: Simplify handling of non-iSCSI and non-NVMe kernel ports
ClosedPublic
Actions

Authored by jhb on May 27 2026, 8:50 PM.
Tags
None
Referenced Files
F160756130: D57283.diff
Sat, Jun 27, 12:41 PM
Unknown Object (File)
Mon, Jun 22, 7:24 AM
Unknown Object (File)
Sat, Jun 20, 12:47 PM
Unknown Object (File)
Tue, Jun 9, 4:05 PM
Unknown Object (File)
Sat, Jun 6, 9:09 AM
Unknown Object (File)
Sat, Jun 6, 7:23 AM
Unknown Object (File)
Fri, Jun 5, 6:55 AM
Unknown Object (File)
Fri, Jun 5, 3:13 AM
View All 12 Files
Subscribers
imp

Details

Reviewers
asomers
kevans
Commits
rG03ac6fe4f6d2: ctld: Simplify handling of non-iSCSI and non-NVMe kernel ports
Summary

Just add these directly to the kports object rather than treating them
as iSCSI ports.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74166
Build 71049: arc lint + arc unit

Event Timeline

jhb created this revision.May 27 2026, 8:50 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 27 2026, 8:50 PM
jhb requested review of this revision.May 27 2026, 8:50 PM
Harbormaster completed remote builds in B73489: Diff 178757.May 27 2026, 8:50 PM
jhb added a child revision: D57092: ctld: Refactor ioctl port handling.May 27 2026, 8:52 PM
jhb removed a child revision: D57092: ctld: Refactor ioctl port handling.May 27 2026, 8:55 PM
jhb mentioned this in D57270: ctld: More consistent error messages.May 28 2026, 4:40 PM
jhb added inline comments.
usr.sbin/ctld/kernel.cc
450–451

With the change to only call this for "iscsi" ports, it is debatable if we should be adding those ports to kports here.

jhb updated this revision to Diff 180463.Tue, Jun 23, 9:09 PM

Rebase and refactor

Harbormaster completed remote builds in B74166: Diff 180463.Tue, Jun 23, 9:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jun 24, 3:29 PM
Closed by commit rG03ac6fe4f6d2: ctld: Simplify handling of non-iSCSI and non-NVMe kernel ports (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG03ac6fe4f6d2: ctld: Simplify handling of non-iSCSI and non-NVMe kernel ports.

Revision Contents
Changeset List

PathSize
usr.sbin/
ctld/
35 lines

Diff 180463

View Options

usr.sbin/ctld/kernel.cc

Loading...