Page MenuHomeFreeBSD

ctld: More consistent error messages
ClosedPublic

Authored by des on Wed, May 27, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 11, 2:58 AM
Unknown Object (File)
Sat, Jun 6, 8:53 PM
Unknown Object (File)
Sat, Jun 6, 8:30 PM
Unknown Object (File)
Sat, Jun 6, 4:46 PM
Unknown Object (File)
Sat, Jun 6, 9:33 AM
Unknown Object (File)
Sat, Jun 6, 2:21 AM
Unknown Object (File)
Fri, Jun 5, 10:13 PM
Unknown Object (File)
Thu, Jun 4, 7:27 PM
Subscribers

Details

Summary

The error messages ctld emits when it finds a port or LUN it did not
create were inconsistent with each other as well as with ctld's other
error messages.

MFC after: 1 week
Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Wed, May 27, 11:25 AM

differentiate iscsi / nvmeof

usr.sbin/ctld/kernel.cc
449–450

Hmm, I change this a bit in D57283. One key thing is that we actually _don't_ ignore "iscsi" ports without a valid target string since we add them to kports (though possibly we should?), but we do currently ignore "nvmf" ports without a valid target.

jhb added inline comments.
usr.sbin/ctld/kernel.cc
449–450

s/should/shouldn't/. But that is probably a better topic for my other change anyway.

501–502

Typical spelling in the tree today is no hyphen.

This revision is now accepted and ready to land.Thu, May 28, 4:45 PM
This revision was automatically updated to reflect the committed changes.