Differential D57270

ctld: More consistent error messages
ClosedPublic
Actions

Authored by des on May 27 2026, 11:25 AM.

Details

Reviewers

jhb

Group Reviewers

Klara

Commits

rG689206379f4c: ctld: More consistent error messages
rG95fc64cc29fb: ctld: More consistent error messages

Summary

The error messages ctld emits when it finds a port or LUN it did not
create were inconsistent with each other as well as with ctld's other
error messages.

MFC after: 1 week
Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.May 27 2026, 11:25 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 27 2026, 11:25 AM

des requested review of this revision.May 27 2026, 11:25 AM

Harbormaster completed remote builds in B73475: Diff 178717.May 27 2026, 11:25 AM

differentiate iscsi / nvmeof

Harbormaster completed remote builds in B73509: Diff 178831.May 28 2026, 4:37 PM

nit

Harbormaster completed remote builds in B73510: Diff 178832.May 28 2026, 4:39 PM

jhb added inline comments.May 28 2026, 4:40 PM

usr.sbin/ctld/kernel.cc
449–450	Hmm, I change this a bit in D57283. One key thing is that we actually _don't_ ignore "iscsi" ports without a valid target string since we add them to kports (though possibly we should?), but we do currently ignore "nvmf" ports without a valid target.

jhb accepted this revision.May 28 2026, 4:45 PM

jhb added inline comments.

usr.sbin/ctld/kernel.cc
449–450	s/should/shouldn't/. But that is probably a better topic for my other change anyway.
501–502	Typical spelling in the tree today is no hyphen.