Page MenuHomeFreeBSD
Differential D57283

ctld: Simplify handling of non-iSCSI and non-NVMe kernel ports
Needs ReviewPublic
Actions

Authored by jhb on Wed, May 27, 8:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 22, 7:24 AM
Unknown Object (File)
Sat, Jun 20, 12:47 PM
Unknown Object (File)
Tue, Jun 9, 4:05 PM
Unknown Object (File)
Sat, Jun 6, 9:09 AM
Unknown Object (File)
Sat, Jun 6, 7:23 AM
Unknown Object (File)
Fri, Jun 5, 6:55 AM
Unknown Object (File)
Fri, Jun 5, 3:13 AM
Unknown Object (File)
Thu, Jun 4, 2:38 PM
View All 11 Files
Subscribers
imp

Details

Reviewers
asomers
kevans
Summary

Just add these directly to the kports object rather than treating them
as iSCSI ports.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73489
Build 70372: arc lint + arc unit

Event Timeline

jhb created this revision.Wed, May 27, 8:50 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, May 27, 8:50 PM
jhb requested review of this revision.Wed, May 27, 8:50 PM
Harbormaster completed remote builds in B73489: Diff 178757.Wed, May 27, 8:50 PM
jhb added a child revision: D57092: ctld: Refactor ioctl port handling.Wed, May 27, 8:52 PM
jhb removed a child revision: D57092: ctld: Refactor ioctl port handling.Wed, May 27, 8:55 PM
jhb mentioned this in D57270: ctld: More consistent error messages.Thu, May 28, 4:40 PM
jhb added inline comments.
usr.sbin/ctld/kernel.cc
451

With the change to only call this for "iscsi" ports, it is debatable if we should be adding those ports to kports here.

Revision Contents
Changeset List

PathSize
usr.sbin/
ctld/
12 lines

Diff 178757

View Options

usr.sbin/ctld/kernel.cc

Loading...