Differential D57721
zfs: drop duplicate vfs.zfs.metaslab.condense_pct sysctl Authored by chris.longros_gmail.com on Sun, Jun 21, 10:35 AM. Tags None Referenced Files
Details
metaslab.c already registers this tunable via ZFS_MODULE_PARAM, so the SYSCTL_UINT here is a second registration of the same leaf: sysctl_register_oid: can't re-use a leaf (vfs.zfs.metaslab.condense_pct) Remove it, as OpenZFS upstream did. Signed-off-by: Christos Longros <chris.longros@gmail.com> Tested on FreeBSD 16.0-CURRENT: the warning is gone and vfs.zfs.metaslab.condense_pct still reads and writes.
Diff Detail
Event TimelineComment Actions Hm, I thought this was fixed by @mm's rGb1b4871f373e9f2a5defdc1242543be291f5e9d9, but apparently not: sysctl_register_oid: can't re-use a leaf (vfs.zfs.metaslab.condense_pct)! It looks good to me, but I'm not an OpenZFS expert, so probably better wait for an OK from @mm :) Comment Actions In the kind of context that I originally reported based on: I patched the /usr/main-src/ tree that I use for personal kernel and world builds, built the kernels (debug and non-debug), installed them, and boot tested them, and, finally, tested causing zfs.ko to load and tried reading and writing vfs.zfs.metaslab.condense_pct . It all seemed to work just fine, with no complaints being output. That included kldunload of zfs.ko . (My non-personal kernels and worlds are from upstream pkgbase distributions. Not really a natural context for patch testing.) |