Differential D57642

ix(4): Sanitize negative error codes
Needs ReviewPublic
Actions

Authored by pawel.sobczyk_intel.com on Thu, Jun 18, 8:46 AM.

Tags

None

Referenced Files

	F160335385: D57642.id179988.diff
	Tue, Jun 23, 10:08 AM

	Unknown Object (File)
	Sun, Jun 21, 8:48 PM

	Unknown Object (File)
	Sat, Jun 20, 9:24 PM

	Unknown Object (File)
	Fri, Jun 19, 2:41 PM

	Unknown Object (File)
	Fri, Jun 19, 2:58 AM

	Unknown Object (File)
	Thu, Jun 18, 2:46 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Intel Networking
Restricted Owners Package	(Owns No Changed Paths)

Summary

Due to development history FreeBSD driver error codes are reported the same way
as in Linux (as negatives) which is inconsistent with FreeBSD standard. It may
cause unexpected behavior when driver errors are interpreted by a kernel
as syscall handler return values.
This patch converts error codes from negative to positive values for
NVM access functions.

Signed-off-by: Pawel Sobczyk <pawel.sobczyk@intel.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73971
Build 70854: arc lint + arc unit

Event Timeline

pawel.sobczyk_intel.com created this revision.Thu, Jun 18, 8:46 AM

Owners added a reviewer: Restricted Owners Package.Thu, Jun 18, 8:46 AM

Herald added subscribers: ae, imp. · View Herald TranscriptThu, Jun 18, 8:46 AM

Harbormaster completed remote builds in B73971: Diff 179988.Thu, Jun 18, 8:46 AM

pawel.sobczyk_intel.com requested review of this revision.Thu, Jun 18, 8:46 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixgbe/

4 lines

Diff 179988

sys/dev/ixgbe/if_ix.c

Loading...