audit: Add poll / select support
ClosedPublic
Actions

Authored by des on Thu, Jun 4, 10:15 PM.

Details

Reviewers

kevans
csjp
markj

Commits

rG0620c99d278b: audit: Add poll / select support

Summary

It was previously not possible to poll() or select() on the trigger
device, which made implementing proper signal handling in auditd
difficult.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73697
Build 70580: arc lint + arc unit

Event Timeline

des created this revision.Thu, Jun 4, 10:15 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jun 4, 10:15 PM

des requested review of this revision.Thu, Jun 4, 10:15 PM

Harbormaster completed remote builds in B73685: Diff 179239.Thu, Jun 4, 10:15 PM

des added a child revision: D57458: auditd: Further improve signal handling.Thu, Jun 4, 10:15 PM

drop comment

Harbormaster completed remote builds in B73697: Diff 179261.Fri, Jun 5, 7:24 AM

emaste added a subscriber: emaste.Fri, Jun 5, 3:07 PM

We might see if we can get a second opinion from @markj as he's dealt with some select/poll integration issues lately, but this is a pretty simple case.

This revision is now accepted and ready to land.Fri, Jun 5, 3:26 PM

I think this is ok, the selinfo is global so the recent lifetime problems we fixed don't apply here. If it were possible to destroy this device file you'd want to issue seldrain(), but I think that never happens.

des added a child revision: D57451: auditd: Fix signal handling.Fri, Jun 5, 9:39 PM

Closed by commit rG0620c99d278b: audit: Add poll / select support (authored by des). · Explain WhyFri, Jun 5, 9:51 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG0620c99d278b: audit: Add poll / select support.