Differential D57428

LinuxKPI: fix lkpi_pci_get_device() reference counting on device
ClosedPublic
Actions

Authored by bz on Jun 4 2026, 8:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Aug 20, 3:24 PM

	Unknown Object (File)
	Wed, Aug 19, 7:02 PM

	Unknown Object (File)
	Sat, Aug 15, 10:05 AM

	Unknown Object (File)
	Sat, Aug 15, 10:05 AM

	Unknown Object (File)
	Sat, Aug 15, 10:05 AM

	Unknown Object (File)
	Mon, Aug 10, 9:46 AM

	Unknown Object (File)
	Mon, Aug 10, 9:40 AM

	Unknown Object (File)
	Mon, Aug 10, 12:36 AM

View All 37 Files

Subscribers

Details

Reviewers

emaste
dumbbell

Group Reviewers

Commits

rG38734f88a643: LinuxKPI: fix lkpi_pci_get_device() reference counting on device
rGf9a37065b694: LinuxKPI: fix lkpi_pci_get_device() reference counting on device

Summary

In case we are passed an "odev" (a device to start the search from),
that device would have an extra reference. The best way to illustrate
this is to look at for_each_pci_dev() which will return one device
after the other. Upon first return we return a pdev with a reference.
That pdev is then passed in as odev on the next call. If we do not
clear the reference it will be leaked.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Fixes: 910cf345d0ee9 ("LinuxKPI: pci: implement ...")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 73655
Build 70538: arc lint + arc unit

Event Timeline

bz created this revision.Jun 4 2026, 8:41 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptJun 4 2026, 8:41 AM

bz requested review of this revision.Jun 4 2026, 8:41 AM

Harbormaster completed remote builds in B73655: Diff 179184.Jun 4 2026, 8:41 AM

bz added a child revision: D57429: LinuxKPI: pci detach: implement a proper detach (release) path.Jun 4 2026, 9:37 AM

Anyone on this one?

Anyone? Otherwise I'll commit this the next days.

Are there actually any callers with non-NULL odev? (I.e., is this not an issue in practice today)

Oh, via for_each_pci_dev of course

LGTM

This revision is now accepted and ready to land.Jul 9 2026, 9:37 PM

dumbbell accepted this revision.Jul 9 2026, 9:42 PM

Closed by commit rGf9a37065b694: LinuxKPI: fix lkpi_pci_get_device() reference counting on device (authored by bz). · Explain WhyJul 13 2026, 2:59 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGf9a37065b694: LinuxKPI: fix lkpi_pci_get_device() reference counting on device.

bz added a commit: rG38734f88a643: LinuxKPI: fix lkpi_pci_get_device() reference counting on device.Mon, Jul 27, 12:10 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

4 lines

Diff 179184

sys/compat/linuxkpi/common/src/linux_pci.c

Loading...