Page MenuHomeFreeBSD

LinuxKPI: fix lkpi_pci_get_device() reference counting on device
Needs ReviewPublic

Authored by bz on Thu, Jun 4, 8:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 11, 1:59 PM
Unknown Object (File)
Wed, Jun 10, 5:51 PM
Unknown Object (File)
Wed, Jun 10, 5:32 AM
Unknown Object (File)
Tue, Jun 9, 11:33 AM
Unknown Object (File)
Tue, Jun 9, 1:59 AM
Unknown Object (File)
Mon, Jun 8, 6:54 AM
Unknown Object (File)
Sun, Jun 7, 2:55 AM
Unknown Object (File)
Sat, Jun 6, 8:55 PM
Subscribers

Details

Reviewers
None
Group Reviewers
linuxkpi
Summary

In case we are passed an "odev" (a device to start the search from),
that device would have an extra reference. The best way to illustrate
this is to look at for_each_pci_dev() which will return one device
after the other. Upon first return we return a pdev with a reference.
That pdev is then passed in as odev on the next call. If we do not
clear the reference it will be leaked.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Fixes: 910cf345d0ee9 ("LinuxKPI: pci: implement ...")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 73655
Build 70538: arc lint + arc unit