xinstall: Do not allow -l and -s together
ClosedPublic
Actions

Authored by emaste on Jun 3 2026, 1:27 AM.

Tags

None

Referenced Files

	F161705880: D57398.diff
	Mon, Jul 6, 3:10 AM

	Unknown Object (File)
	Sun, Jul 5, 7:04 PM

	Unknown Object (File)
	Sat, Jun 20, 11:05 PM

	Unknown Object (File)
	Sat, Jun 20, 11:01 PM

	Unknown Object (File)
	Sat, Jun 20, 10:20 PM

	Unknown Object (File)
	Sat, Jun 20, 10:19 PM

	Unknown Object (File)
	Sat, Jun 20, 10:19 PM

	Unknown Object (File)
	Sat, Jun 20, 10:16 PM

View All 35 Files

Subscribers

imp

Details

Reviewers

des
jrtc27

Group Reviewers

build

Commits

rG4b570289f0cc: xinstall: Do not allow -l and -s together
rG521afce6a859: xinstall: Do not allow -l and -s together

Summary

Cannot strip the target if creating a link.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Jun 3 2026, 1:27 AM

emaste created this revision.

add test

emaste added reviewers: des, jrtc27.Jun 3 2026, 2:28 PM

des accepted this revision.Jun 3 2026, 3:23 PM

This revision is now accepted and ready to land.Jun 3 2026, 3:23 PM

This should probably be documented, though.

Closed by commit rG521afce6a859: xinstall: Do not allow -l and -s together (authored by emaste). · Explain WhyJun 3 2026, 3:33 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG521afce6a859: xinstall: Do not allow -l and -s together.

Herald added a subscriber: imp. · View Herald TranscriptJun 3 2026, 3:33 PM

emaste added a commit: rG4b570289f0cc: xinstall: Do not allow -l and -s together.Wed, Jun 10, 1:45 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

xinstall/

tests/

install_test.sh

3 lines

xinstall.c

6 lines

Diff 179124

View Options

usr.bin/xinstall/tests/install_test.sh