xinstall: Do not allow -l and -s together
ClosedPublic
Actions

Authored by emaste on Jun 3 2026, 1:27 AM.

Details

Reviewers

des
jrtc27

Group Reviewers

build

Commits

rG44eb447094b7: xinstall: Do not allow -l and -s together
rG4b570289f0cc: xinstall: Do not allow -l and -s together
rG521afce6a859: xinstall: Do not allow -l and -s together

Summary

Cannot strip the target if creating a link.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Jun 3 2026, 1:27 AM

emaste created this revision.

add test

emaste added reviewers: des, jrtc27.Jun 3 2026, 2:28 PM

des accepted this revision.Jun 3 2026, 3:23 PM

This revision is now accepted and ready to land.Jun 3 2026, 3:23 PM

This should probably be documented, though.

Closed by commit rG521afce6a859: xinstall: Do not allow -l and -s together (authored by emaste). · Explain WhyJun 3 2026, 3:33 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG521afce6a859: xinstall: Do not allow -l and -s together.

Herald added a subscriber: imp. · View Herald TranscriptJun 3 2026, 3:33 PM

emaste added a commit: rG4b570289f0cc: xinstall: Do not allow -l and -s together.Jun 10 2026, 1:45 PM

des added a commit: rG44eb447094b7: xinstall: Do not allow -l and -s together.Jul 28 2026, 9:34 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

xinstall/

tests/

install_test.sh

3 lines

xinstall.c

6 lines

Diff 179124

View Options

usr.bin/xinstall/tests/install_test.sh