Paths

Table of Contentst

Differential D57295

Mk/bsd.port.mk: Add EXTRACT_ENV
ClosedPublic
Actions

Authored by des on May 28 2026, 10:43 AM.

Tags

None

Referenced Files

	F160796277: D57295.diff
	Sat, Jun 27, 11:20 PM

	Unknown Object (File)
	Fri, Jun 26, 6:51 AM

	Unknown Object (File)
	Sun, Jun 21, 1:43 PM

	Unknown Object (File)
	Fri, Jun 12, 2:38 PM

	Unknown Object (File)
	Wed, Jun 10, 10:49 AM

	Unknown Object (File)
	Tue, Jun 9, 3:28 AM

	Unknown Object (File)
	Tue, Jun 9, 3:23 AM

	Unknown Object (File)
	Sun, Jun 7, 2:00 PM

View All 18 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R11:e3ac6cd83ce9: Mk/bsd.port.mk: Add EXTRACT_ENV
R11:98103f194302: Mk/bsd.port.mk: Add EXTRACT_ENV

Summary

Add an EXTRACT_ENV variable which defaults to LC_ALL=C.UTF-8. We set
LC_ALL=C globally to ensure our scripts work the way we intend them to,
but this causes tar and unzip to fail to extract distfiles containing
names that cannot be expressed in ASCII. This was previously masked by
a bug in libarchive which caused tar and unzip to fail to notice that
these names were unconvertible and just pass them through unchanged.

MFH: 2026Q2

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73499
Build 70382: arc lint + arc unit

Event Timeline

des requested review of this revision.May 28 2026, 10:43 AM

des created this revision.

Harbormaster completed remote builds in B73499: Diff 178799.May 28 2026, 10:43 AM

bapt accepted this revision.May 28 2026, 11:17 AM

This revision is now accepted and ready to land.May 28 2026, 11:17 AM

Closed by commit R11:98103f194302: Mk/bsd.port.mk: Add EXTRACT_ENV (authored by des). · Explain WhyMay 28 2026, 2:33 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: R11:98103f194302: Mk/bsd.port.mk: Add EXTRACT_ENV.

des added a commit: R11:e3ac6cd83ce9: Mk/bsd.port.mk: Add EXTRACT_ENV.

arrowd added a subscriber: arrowd.May 28 2026, 2:52 PM

arrowd added inline comments.

Mk/bsd.port.mk
3217–3218	Shouldn't this also have `${SETENV}` before `${EXTRACT_ENV}`. This is how all other *_ENV knobs are used.

des added inline comments.May 28 2026, 4:07 PM

Mk/bsd.port.mk
3217–3218	I can add it for consistency's sake, but it isn't actually needed, and it adds a small amount of overhead.

thierry mentioned this in R11:dca58708f52c: lang/gnat1[2-4]: Restore check-phase.Sun, Jun 7, 10:58 AM

Revision Contents
Changeset List

Path

Size

Mk/

5 lines

Diff 178799

Mk/bsd.port.mk

Loading...