sys/dts: Add SD card overlays for the BananaPi-F3 SoC
Needs ReviewPublic
Actions

Authored by bnovkov on Fri, May 22, 6:37 PM.

Details

Reviewers

manu
mhorne

Group Reviewers

riscv

Summary

The K1 user manual lists three separate SDHCI devices but the
upstream DTS file only defines the eMMC device.

Create a temporary overlay to allow the BananaPi-F3 to boot from the
SD card until this is addressed upstream.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73348
Build 70231: arc lint + arc unit

Event Timeline

bnovkov created this revision.Fri, May 22, 6:37 PM

Herald added a reviewer: manu. · View Herald TranscriptFri, May 22, 6:37 PM

Herald added a subscriber: imp. · View Herald Transcript

bnovkov requested review of this revision.Fri, May 22, 6:37 PM

Harbormaster completed remote builds in B73348: Diff 178421.Fri, May 22, 6:37 PM

bnovkov added a parent revision: D57176: clk: Initial support for the SpacemiT K1 clock control units.Fri, May 22, 6:37 PM

bnovkov added a child revision: D57178: sdhci: Initial support for the SpacemiT K1 sdhci controller.

Seems good to bring these in.

Are you running with mainline u-boot? I have not kept track of its status for this hardware.

sys/modules/dtb/spacemit/Makefile
2–3	Did you copy these from somewhere? I do not understand the naming strategy in use here. Why not combine them into a single overlay?

Address @mhorne 's comments.

In D57177#1311153, @mhorne wrote:

Seems good to bring these in.

Are you running with mainline u-boot? I have not kept track of its status for this hardware.

Unfortunately no, I'm running the vendor's build (uboot 2022.10) since upstream support is not quite there yet.
I think that's going to change soon though, several K1-related patch series have been created in the last couple of months (e.g., CCU driver).
I have a set of scripts that I use to build the final image from the vendor's artifacts until mainline uboot is ready, I plan on converting those into a wiki page soon.

sys/modules/dtb/spacemit/Makefile
2–3	I think my initial intention was to split the overlays into an SoC-specific and a CPU-specific file, but looking back at this I think you're right, it makes more sense to have them in a single file.

LGTM.

In D57177#1314391, @bnovkov wrote:

Unfortunately no, I'm running the vendor's build (uboot 2022.10) since upstream support is not quite there yet.
I think that's going to change soon though, several K1-related patch series have been created in the last couple of months (e.g., CCU driver).
I have a set of scripts that I use to build the final image from the vendor's artifacts until mainline uboot is ready, I plan on converting those into a wiki page soon.

That sounds great, thanks. I know there are some others with this hardware who will be curious to try it again.