Page MenuHomeFreeBSD

sdhci: Initial support for the SpacemiT K1 sdhci controller
AcceptedPublic

Authored by bnovkov on Fri, May 22, 6:37 PM.

Details

Reviewers
mhorne
Group Reviewers
riscv
Test Plan

Tested on a Banana Pi BPI-F3 board, the driver successfully attaches to the SD card :

[[snip]]
sdhci_spacemit0: <SpacemiT K1 SDHCI controller> mem 0xd4280000-0xd42801ff irq 43 on simplebus6
sdhci_spacemit0-slot0: Hardware doesn't specify timeout clock frequency, setting BROKEN_TIMEOUT quirk.
sdhci_spacemit0-slot0: 208MHz 8bits VDD: VCCQ: 3.3V DRV: BACD DMA removable
sdhci_spacemit0-slot0: ============== REGISTER DUMP ==============
sdhci_spacemit0-slot0: Sys addr: 0x00000000 | Version:  0x00000002
sdhci_spacemit0-slot0: Blk size: 0x00007040 | Blk cnt:  0x00000000
sdhci_spacemit0-slot0: Argument: 0x80fffff1 | Trn mode: 0x00000013
sdhci_spacemit0-slot0: Present:  0x01f70000 | Host ctl: 0x0000001e
sdhci_spacemit0-slot0: Power:    0x0000000f | Blk gap:  0x00000000
sdhci_spacemit0-slot0: Wake-up:  0x00000000 | Clock:    0x00000307
sdhci_spacemit0-slot0: Timeout:  0x0000000e | Int stat: 0x00000000
sdhci_spacemit0-slot0: Int enab: 0x027f003b | Sig enab: 0x027f003b
sdhci_spacemit0-slot0: AC12 err: 0x00000000 | Host ctl2:0x00004008
sdhci_spacemit0-slot0: Caps:     0x35fc0080 | Caps2:    0x00002f77
sdhci_spacemit0-slot0: Max curr: 0x00000000 | ADMA err: 0x00000000
sdhci_spacemit0-slot0: ADMA addr:0x7deb234c | Slot int: 0x00000000
sdhci_spacemit0-slot0: ===========================================
sdhci_spacemit0: 1 slot(s) allocated
sdhci_spacemit0-slot0: Card inserted
mmc0: <MMC/SD bus> on sdhci_spacemit0
[[snip]]

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73349
Build 70232: arc lint + arc unit

Event Timeline

mhorne added a subscriber: mhorne.
mhorne added inline comments.
sys/dev/sdhci/sdhci_fdt_spacemit.c
12

Please double check the includes, the list seems like more than necessary. Certainly taskqueue.h is not needed here, at the very least.

This revision is now accepted and ready to land.Sun, May 24, 5:10 PM