Page MenuHomeFreeBSD
Differential D56400

glabel(8): Fix debug message for already existing labels
ClosedPublic
Actions

Authored by michaelo on Wed, Apr 15, 8:13 AM.
Tags
None
Referenced Files
F153817265: D56400.id175594.diff
Fri, Apr 24, 12:08 AM
Unknown Object (File)
Tue, Apr 21, 12:20 PM
Unknown Object (File)
Tue, Apr 21, 11:21 AM
Unknown Object (File)
Tue, Apr 21, 10:20 AM
Unknown Object (File)
Tue, Apr 21, 9:27 AM
Unknown Object (File)
Tue, Apr 21, 2:46 AM
Unknown Object (File)
Mon, Apr 20, 11:04 AM
Unknown Object (File)
Sun, Apr 19, 1:12 AM
View All 13 Files
Subscribers
None

Details

Reviewers
mav
markj
imp
Commits
rG0fda88fa010f: glabel(8): Fix debug message for already existing labels
rG5131d206877c: glabel(8): Fix debug message for already existing labels
rGc93e8b63d62b: glabel(8): Fix debug message for already existing labels
rG92c69c791c43: glabel(8): Fix debug message for already existing labels
Summary

Remove the duplicate (incorrect) name.

PR: 294542
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72212
Build 69095: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Wed, Apr 15, 8:13 AM
michaelo created this revision.
Harbormaster completed remote builds in B72212: Diff 175536.Wed, Apr 15, 8:13 AM
markj added inline comments.Wed, Apr 15, 1:23 PM
sys/geom/label/g_label.c
255

Just don't print pp2->name at all? We already know it's the same as name.

michaelo updated this revision to Diff 175585.Wed, Apr 15, 4:05 PM

Remove the duplicate (incorrect) name.

Harbormaster completed remote builds in B72232: Diff 175585.Wed, Apr 15, 4:05 PM
michaelo edited the summary of this revision. (Show Details)Wed, Apr 15, 4:06 PM
michaelo marked an inline comment as done.
michaelo added inline comments.
sys/geom/label/g_label.c
255

Totally right!

markj accepted this revision.Wed, Apr 15, 4:07 PM
This revision is now accepted and ready to land.Wed, Apr 15, 4:07 PM
Closed by commit rG92c69c791c43: glabel(8): Fix debug message for already existing labels (authored by michaelo). · Explain WhyWed, Apr 15, 6:19 PM
This revision was automatically updated to reflect the committed changes.
michaelo marked an inline comment as done.
michaelo added a commit: rG92c69c791c43: glabel(8): Fix debug message for already existing labels.
michaelo added a commit: rGc93e8b63d62b: glabel(8): Fix debug message for already existing labels.Wed, Apr 22, 9:31 AM
michaelo added a commit: rG5131d206877c: glabel(8): Fix debug message for already existing labels.
michaelo added a commit: rG0fda88fa010f: glabel(8): Fix debug message for already existing labels.Wed, Apr 22, 9:35 AM

Revision Contents
Changeset List

PathSize
sys/
geom/
label/
4 lines

Diff 175536

View Options

sys/geom/label/g_label.c

Loading...